Closed Bug 1730018 Opened 3 years ago Closed 3 years ago

Update footer under the Pocket section on newtab.

Categories

(Firefox :: Pocket, enhancement)

enhancement

Tracking

()

VERIFIED FIXED
94 Branch
Tracking Status
firefox94 --- verified
firefox99 --- verified
firefox100 --- verified

People

(Reporter: thecount, Assigned: thecount)

References

(Blocks 1 open bug)

Details

Attachments

(1 file)

We want to try updating and polishing the topics navigation section in our upcoming newtab experiments.

Blocks: 1717682
Blocks: 1717892
No longer blocks: 1717682

Updating this to include all Pocket section footer work, including changes to the privacy link location and the "this is part of the Pocket family" blerb.

Summary: Update topics navigation under the Pocket section on newtab. → Update footer under the Pocket section on newtab.

To test:

  1. Set browser.newtabpage.activity-stream.discoverystream.newFooterSection.enabled to true
  2. Open a new newtab
  3. Expected: should see a new topics section with 7 topics and a more link.
    4 Expected: links should click and work.
  4. Expected: Privacy link should now be at the bottom of the page, centred.
  5. Expected: Should also see a "Part of the firefox family" type section next to 2 logos under the topics section.
  6. Turn off the new pref, and open a new newtab
  7. Expected: Should go back to the old topics section.
Assignee: nobody → sdowne
Status: NEW → ASSIGNED
Pushed by sdowne@getpocket.com:
https://hg.mozilla.org/integration/autoland/rev/cf25b698293b
New Pocket footer section on newtab r=gvn,fluent-reviewers,flod
Status: ASSIGNED → RESOLVED
Closed: 3 years ago
Resolution: --- → FIXED
Target Milestone: --- → 94 Branch
Flags: qe-verify+

I tested this enhacement on Firefox 94(20211028161635), Firefox 98(20220304153049) and Nightly 99.0a1(20220307190508). Based on comment 3, the footer is displayed as expected, but the links from step 3 are not working. This seems to be an issue even if browser.newtabpage.activity-stream.discoverystream.newFooterSection.enabled is set back to false. I'm leaving a link for a recording of this issue for more clarity.

Screen Recording

Flags: needinfo?(sdowne)

Looking at that video, it looks like something was wrong with getpocket.com, and not the links on newtab.

They work for me now, maybe it's fixed now for you too? Mind trying again?

Flags: needinfo?(sdowne) → needinfo?(oana.ardelean)

I tested again on Firefox 94(20211028161635), Firefox 99.0b1(20220308094525) and Nightly 100.0a1(20220308220159). I covered macOS 11, Linux(Ubuntu 20.04) and Win10 64-bit. The links work perfectly now and everything is placed accordingly based on your comment.
Thank you!

Status: RESOLVED → VERIFIED
Flags: qe-verify+
Flags: needinfo?(oana.ardelean)
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: