1730086 - TextLeafPoint: Implement HyperTextAccessible::TextBefore/AfterOffset using TextLeafPoint

Status: RESOLVED FIXED

(Core :: Disability Access APIs, task)

Description

[James Teh [:Jamie]]

In bug 1729407, code was added to HyperTextAccessible::TextAtOffset to use TextLeafPoint. We also need code that can use TextLeafPoint for TextBeforeOffset and TextAfterOffset.

Comment 1

[James Teh [:Jamie]]

Attachment: Bug 1730086 part 1: Implement HyperTextAccessibleBase::TextBefore/AfterOffset using TextLeafPoint.

As with TextAtOffset, the local HyperTextAccessible methods use the base implementation when the cache is enabled.

Comment 2

[James Teh [:Jamie]]

Attachment: Bug 1730086 part 2: Fix HyperTextAccessibleBase::TextBeforeOffset when called just after two consecutive line feeds.

This was due to a bug in TextLeafPoint::FindPrevWordStartSameAcc which hasn't been exposed before now.

Comment 3

[James Teh [:Jamie]]

Attachment: Bug 1730086 part 3: Rename RemoteAccessible::GetTextBefore/AfterOffset to TextBefore/AfterOffset, have it override HyperTextAccessibleBase and use the base methods in ATK/XPCOM.

Comment 4

[James Teh [:Jamie]]

Attachment: Bug 1730086 part 4: Support IAccessibleText::textBefore/AfterOffset for cached RemoteAccessibles.

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/23d41a667bc1
part 1: Implement HyperTextAccessibleBase::TextBefore/AfterOffset using TextLeafPoint. r=morgan
https://hg.mozilla.org/integration/autoland/rev/6d9cfbb51c7a
part 2: Fix HyperTextAccessibleBase::TextBeforeOffset when called just after two consecutive line feeds. r=morgan
https://hg.mozilla.org/integration/autoland/rev/f9136c2f4cd0
part 3: Rename RemoteAccessible::GetTextBefore/AfterOffset to TextBefore/AfterOffset, have it override HyperTextAccessibleBase and use the base methods in ATK/XPCOM. r=morgan
https://hg.mozilla.org/integration/autoland/rev/98bebfa0d73b
part 4: Support IAccessibleText::textBefore/AfterOffset for cached RemoteAccessibles. r=morgan

Comment 6

[Norisz Fay [:noriszfay]]

https://hg.mozilla.org/mozilla-central/rev/23d41a667bc1
https://hg.mozilla.org/mozilla-central/rev/6d9cfbb51c7a
https://hg.mozilla.org/mozilla-central/rev/f9136c2f4cd0
https://hg.mozilla.org/mozilla-central/rev/98bebfa0d73b