1730217 - about:preferences#general doesn't display (in or out of Troubleshooting Mode)

Status: VERIFIED FIXED

(Firefox :: Settings UI, defect, P1)

Description

[B.J. Herbison]

My about:preferences#general doesn't display in Troubleshooting Mode. I get these messages in the console:
Error initializing preference category paneGeneral: TypeError: can't access property "getAttribute", aElemKey is null preferences.js:287
gotoPref chrome://browser/content/preferences/preferences.js:287
AsyncFunctionThrow self-hosted:696
Uncaught (in promise) TypeError: can't access property "getAttribute", aElemKey is null
prettifyShortcut resource://gre/modules/ShortcutUtils.jsm:55
init chrome://browser/content/preferences/main.js:443
init chrome://browser/content/preferences/preferences.js:106
ShortcutUtils.jsm:55:22
Uncaught (in promise) TypeError: can't access property "getAttribute", aElemKey is null
prettifyShortcut resource://gre/modules/ShortcutUtils.jsm:55
init chrome://browser/content/preferences/main.js:443
init chrome://browser/content/preferences/preferences.js:106
initializeCategories chrome://browser/content/preferences/findInPage.js:96
init chrome://browser/content/preferences/findInPage.js:52
ShortcutUtils.jsm:55:22

Comment 1

[Jim Jeffery not reading bug-mail 1/2/11]

WFM win10, today's Nightly

Comment 2

[Tom S [:evilpie]]

I can reproduce this. This is caused by "key_quitApplication" not existing due to browser.quitShortcut.disabled = true.

Comment 3

[Neil Deakin]

Attachment: Bug 1730217, hide keyboard shortcut warning checkbox if the browser.quitShortcut.disabled preference if enabled, r=mhowell

Comment 4

[BugBot [:suhaib / :marco/ :calixte]]

Set release status flags based on info from the regressing bug 1726736

Comment 5

[Jared Wein [:jaws] (please needinfo? me)]

Flagging as P1 since it is assigned and setting severity as S3 since this affects opening of preferences if a setting is configured.

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/aa33fb205e9e
hide keyboard shortcut warning checkbox if the browser.quitShortcut.disabled preference if enabled, r=mhowell,preferences-reviewers,jaws

Comment 7

[Cristina Cozmuta (:CrissCozmuta)]

https://hg.mozilla.org/mozilla-central/rev/aa33fb205e9e

Comment 8

[B.J. Herbison]

The fix works for me.

Comment 9

[Ciprian Georgiu, Desktop QA]

Reproduced this bug on macOS 11, with an affected Nightly build from 2021-09-10.

The issue is verified as fixed on latest Beta 94.0b4, across platforms: Win 11, macOS 11 and Ubuntu 18.04 x64.