1730250 - about:processes thread summary rows should show threads from thread pools as a single item

Status: RESOLVED FIXED

(Toolkit :: Performance Monitoring, enhancement)

Description

[Florian Quèze [:florian]]

The list of active threads shown in thread summary rows since bug 1709811 is often long, especially when some thread pools are active. I think it would look nicer to display a single item for threads from thread pools.

Comment 1

[Florian Quèze [:florian]]

Attachment: Bug 1730250 - about:processes thread summary rows should show threads from thread pools as a single item, r=dthayer.

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/654b2804c1e9
about:processes thread summary rows should show threads from thread pools as a single item, r=dthayer.

Comment 3

[Natalia Csoregi [:nataliaCs]]

Backed out along with Bug 1730239 for failures on browser_aboutprocesses_default_options.js

• backout: https://hg.mozilla.org/integration/autoland/rev/8b88fb8e82326692089503b9f6b1abea0dfb5b43

• push: https://treeherder.mozilla.org/jobs?repo=autoland&revision=654b2804c1e907b11e5fb8fe42ff2c0aa3064895&group_state=expanded&selectedTaskRun=EGp6roAcRIiT3af60SfKQw.0

• failure log: https://treeherder.mozilla.org/logviewer?job_id=351667253&repo=autoland&lineNumber=5191

[task 2021-09-15T19:33:11.421Z] 19:33:11     INFO - TEST-PASS | toolkit/components/aboutprocesses/tests/browser/browser_aboutprocesses_default_options.js | There is a separate process for the tab with a different user context - [object HTMLTableRowElement] == true - 
[task 2021-09-15T19:33:11.423Z] 19:33:11     INFO - Buffered messages finished
[task 2021-09-15T19:33:11.424Z] 19:33:11     INFO - TEST-UNEXPECTED-FAIL | toolkit/components/aboutprocesses/tests/browser/browser_aboutprocesses_default_options.js | Uncaught exception - at chrome://mochitests/content/browser/toolkit/components/aboutprocesses/tests/browser/head.js:860 - TypeError: can't access property "origin", document.l10n.getAttributes(...).args is null
[task 2021-09-15T19:33:11.424Z] 19:33:11     INFO - Stack trace:
[task 2021-09-15T19:33:11.424Z] 19:33:11     INFO - testAboutProcessesWithConfig@chrome://mochitests/content/browser/toolkit/components/aboutprocesses/tests/browser/head.js:860:21
[task 2021-09-15T19:33:11.425Z] 19:33:11     INFO - Leaving test bound testDefaultOptions
[task 2021-09-15T19:33:11.426Z] 19:33:11     INFO - Not taking screenshot here: see the one that was previously logged
[task 2021-09-15T19:33:11.427Z] 19:33:11     INFO - TEST-UNEXPECTED-FAIL | toolkit/components/aboutprocesses/tests/browser/browser_aboutprocesses_default_options.js | Extension left running at test shutdown - 
[task 2021-09-15T19:33:11.427Z] 19:33:11     INFO - Stack trace:
[task 2021-09-15T19:33:11.427Z] 19:33:11     INFO - chrome://mochikit/content/browser-test.js:test_ok:1336
[task 2021-09-15T19:33:11.427Z] 19:33:11     INFO - chrome://mochikit/content/tests/SimpleTest/ExtensionTestUtils.js:ExtensionTestUtils.loadExtension/<:117
[task 2021-09-15T19:33:11.428Z] 19:33:11     INFO - chrome://mochikit/content/browser-test.js:nextTest:561
[task 2021-09-15T19:33:11.430Z] 19:33:11     INFO - GECKO(2504) | [Child 2592, Main Thread] WARNING: '!CanSend() || !mManager || !mManager->CanSend()', file /builds/worker/checkouts/gecko/dom/ipc/jsactor/JSWindowActorChild.cpp:44
[task 2021-09-15T19:33:11.430Z] 19:33:11     INFO - GECKO(2504) | MEMORY STAT vsizeMaxContiguous not supported in this build configuration.
[task 2021-09-15T19:33:11.432Z] 19:33:11     INFO - GECKO(2504) | MEMORY STAT | vsize 3028MB | residentFast 430MB | heapAllocated 178MB
[task 2021-09-15T19:33:11.432Z] 19:33:11     INFO - TEST-OK | toolkit/components/aboutprocesses/tests/browser/browser_aboutprocesses_default_options.js | took 6604ms

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/fffaef4c2844
about:processes thread summary rows should show threads from thread pools as a single item, r=dthayer.

Comment 5

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

https://hg.mozilla.org/mozilla-central/rev/fffaef4c2844