Closed Bug 1730256 Opened 3 years ago Closed 3 years ago

[wpt-sync] Sync PR 30555 - Move getWindowSegments to visualViewport.segments

Categories

(Core :: DOM: Core & HTML, task, P4)

Product:
Core
Component:
DOM: Core & HTML
Type:
task

Tracking

()

Status:
RESOLVED FIXED
Milestone:
95 Branch
Tracking Flags:
Tracking Status
firefox95 --- fixed

People

(Reporter: mozilla.org, Unassigned)

References

(
URL
)

Details

(Whiteboard: [wptsync downstream])

Sync web-platform-tests PR 30555 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/30555
Details from upstream follow.

b'Daniel Libby <dlibby@microsoft.com>' wrote:

Move getWindowSegments to visualViewport.segments

In order to align the CSS and JavaScript concepts, we are slightly
changing the shape of the API. Instead of a function off of Window,
we'll have a segments property on VisualViewport which more closely
reflects the concept of segments/regions of the viewport where content
can be placed.

https://wicg.github.io/visual-viewport/index.html#dom-visualviewport-segments

Bug: 1039050
Change-Id: Ia30742c8f2b4b2d4011f8b45e0c532bc8bf286a1
Reviewed-on: https://chromium-review.googlesource.com/3153295
WPT-Export-Revision: 34ea6f047565469c58bd92bc3369c1a9a20245ab

Component: web-platform-tests → Layout
Product: Testing → Core
Component: Layout → DOM: Core & HTML

CI Results

Ran 11 Firefox configurations based on mozilla-central, and Firefox, Chrome, and Safari on GitHub CI

Total 2 tests and 1 subtests

Status Summary

Firefox

OK : 2
PASS: 39
FAIL: 3

Chrome

OK : 2
PASS: 39
FAIL: 3

Safari

OK : 2
PASS: 39
FAIL: 3

Links

Gecko CI (Treeherder)
GitHub PR Head
GitHub PR Base

Details

New Tests That Don't Pass

/visual-viewport/idlharness.window.html
VisualViewport interface: attribute segments: FAIL (Chrome: FAIL, Safari: FAIL)
VisualViewport interface: self.visualViewport must inherit property "segments" with the proper type: FAIL (Chrome: FAIL, Safari: FAIL)
/visual-viewport/viewport-segments.tentative.html
Viewport Segments: visualViewport.segments tentative: FAIL (Chrome: FAIL, Safari: FAIL)

Pushed by wptsync@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/9439f50ae1ce
[wpt PR 30555] - Move getWindowSegments to visualViewport.segments, a=testonly
https://hg.mozilla.org/integration/autoland/rev/4cd527c3c46c
[wpt PR 30555] - Update wpt metadata, a=testonly
Pushed by wptsync@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/756ec6ee01f7
[wpt PR 30555] - Move getWindowSegments to visualViewport.segments, a=testonly
https://hg.mozilla.org/integration/autoland/rev/f0a5873e092b
[wpt PR 30555] - Update wpt metadata, a=testonly

https://hg.mozilla.org/mozilla-central/rev/756ec6ee01f7
https://hg.mozilla.org/mozilla-central/rev/f0a5873e092b

Status: NEW → RESOLVED
Closed: 3 years ago
status-firefox95: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 95 Branch
You need to log in before you can comment on or make changes to this bug.