1730265 - Build errors in SandboxTestingChild.cpp, SandboxTestingParent.cpp with --disable-unified-build

Status: RESOLVED FIXED

(Core :: Security: Process Sandboxing, defect)

Description

[Daniel Holbert [:dholbert]]

STR:
(1) Build on linux with:

ac_add_options --enable-profiling
ac_add_options --disable-unified-build
ac_add_options --enable-debug --disable-optimize

ACTUAL RESULTS:

security/sandbox/common/test/SandboxTestingChild.cpp:58:33: error: implicit instantiation of undefined template 'mozilla::ipc::Endpoint<mozilla::PSandboxTestingChild>'
   DebugOnly<bool> ok = aEndpoint.Bind(this);

security/sandbox/common/test/SandboxTestingParent.cpp:36:28: error: implicit instantiation of undefined template 'mozilla::ipc::Endpoint<mozilla::PSandboxTestingParent>'
   DebugOnly<bool> ok = aEnd.Bind(this);

security/sandbox/common/test/SandboxTestingParent.cpp:80:18: error: use of undeclared identifier 'nsIObserverService'
         nsCOMPtr<nsIObserverService> observerService =

security/sandbox/common/test/SandboxTestingParent.cpp:81:22: error: no member named 'services' in namespace 'mozilla'
             mozilla::services::GetObserverService();

Comment 1

[Daniel Holbert [:dholbert]]

Attachment: Bug 1730265: Add includes to SandboxTestingChild.cpp and SandboxTestingParent.cpp to fix build errors with --disable-unified-build. r?handyman

These includes provide some types and functionality that these files need. In
the default build environment, there's no issue because they pick up these
includes via piggybacking on neighboring files that they're unified with; but
in a non-unified build, the files need to directly have these includes, to
avoid build errors.

See https://bugzilla.mozilla.org/show_bug.cgi?id=1730265#c0 for the specific
build errors being addressed here.

Comment 2

[Daniel Holbert [:dholbert]]

With the attached patch, my build (with mozconfig from comment 0) completes successfully.

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/792f25f1405d
Add includes to SandboxTestingChild.cpp and SandboxTestingParent.cpp to fix build errors with --disable-unified-build. r=handyman

Comment 4

[Sandor Molnar[:smolnar]]

https://hg.mozilla.org/mozilla-central/rev/792f25f1405d