1730287 - Fix startup.first_run_is_from_dmg telemetry to report first-run-not-from-dmg stats again

Status: RESOLVED FIXED

(Toolkit :: Printing, defect)

Description

[Jonathan Watt [:jwatt]]

After https://phabricator.services.mozilla.com/D122686 landed the startup.first_run_is_from_dmg telemetry stopped reporting stats for is-first-run-but-not-from-dmg cases. That's necessary for us to monitor the ratio of first runs that are from dmg vs those that are not. We should restore the previous behavior.

Comment 1

[Jonathan Watt [:jwatt]]

Attachment: Bug 1730287. Fix startup.first_run_is_from_dmg telemetry to report first-run-not-from-dmg stats. r=mstange

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/c978efe3f395
Fix startup.first_run_is_from_dmg telemetry to report first-run-not-from-dmg stats. r=mstange

Comment 3

[Jonathan Watt [:jwatt]]

[Tracking Requested - why for this release]: Reverting accidental change that broke our telemetry. Necessary to gauge success of macOS first-run work.

Comment 4

[Sandor Molnar[:smolnar]]

https://hg.mozilla.org/mozilla-central/rev/c978efe3f395

Comment 5

[BugBot [:suhaib / :marco/ :calixte]]

The patch landed in nightly and beta is affected.
:jwatt, is this bug important enough to require an uplift?
If not please set status_beta to wontfix.

For more information, please visit auto_nag documentation.

Comment 6

[Pascal Chevrel:pascalc (PTO until April 26)]

Jonathan, should we uplift this patch or can I mark it as wontfix for 93? Thanks

Comment 7

[Jonathan Watt [:jwatt]]

Comment on attachment 9240683 [details]
Bug 1730287. Fix startup.first_run_is_from_dmg telemetry to report first-run-not-from-dmg stats. r=mstange

Beta/Release Uplift Approval Request

• User impact if declined: See comment 0.
• Is this code covered by automated tests?: No
• Has the fix been verified in Nightly?: Yes
• Needs manual test from QE?: No
• If yes, steps to reproduce:
• List of other uplifts needed: None
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): It's a telemetry tweak to revert to the previous behavior.
• String changes made/needed:

Comment 8

[Pascal Chevrel:pascalc (PTO until April 26)]

Comment on attachment 9240683 [details]
Bug 1730287. Fix startup.first_run_is_from_dmg telemetry to report first-run-not-from-dmg stats. r=mstange

Approved for 93 beta 6, thanks.

Comment 9

[Pascal Chevrel:pascalc (PTO until April 26)]

https://hg.mozilla.org/releases/mozilla-beta/rev/14271e05163c