1730312 - Maximize(Restore) window button does not work on Windows 7/8.1

Status: VERIFIED FIXED

(Core :: Widget: Win32, defect)

Description

[Masatoshi Kimura [:emk]]

+++ This bug was initially created as a clone of Bug #1729749 +++

Steps to Reproduce:

1. Open Nightly
2. Click Maximize/Restore Button

Actual Results:
Nothing happens.
Double click on draggable area works as expected.

Expected Results:
Window should be resized.

Comment 1

[Masatoshi Kimura [:emk]]

Windows 7/8.1 uses the system buttons even if the system title bar is disabled. mWindowButtonsRect holds the button area when the system buttons are used.
https://searchfox.org/mozilla-central/rev/1761c710b035d7dc8892dfa8e56589b4e095221f/widget/windows/nsWindow.cpp#4216-4232

Comment 2

[Masatoshi Kimura [:emk]]

Attachment: Bug 1730312 - Do not handle WM_NCLBUTTONDOWN if the system buttons are used. r?handyman

Windows 7/8.1 uses the system buttons even if the system title bar is disabled. mWindowButtonsRect holds the button area when the system buttons are used.

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/33ac1420d915
Do not handle WM_NCLBUTTONDOWN if the system buttons are used. r=handyman

Comment 4

[Narcis Beleuzu [:NarcisB]]

https://hg.mozilla.org/mozilla-central/rev/33ac1420d915

Comment 5

[Gabi Cheta [:Gabi] Desktop QA]

Reproduced the issue on Windows 8.1 x64 with Fx Nightly(2021-09-10).
Verified as fixed with Windows 8.1 x64 and Windows 7 x64 Firefox Nightly 95.0a1 and Fx 94.0b4.