1730389 - Crash in [@ InvalidArrayIndex_CRASH | nsMsgFilterAfterTheFact::ApplyFilter]

Status: RESOLVED FIXED

(Thunderbird :: General, defect)

Description

[Wayne Mery (:wsmwk)]

another example of bug 1729778?

#47 crash for TB 91.1.0

Crash report: https://crash-stats.mozilla.org/report/index/151f2767-0f31-4459-af3a-570730210911

MOZ_CRASH Reason: ElementAt(aIndex = 0, aLength = 0)

Top 10 frames of crashing thread:

0 xul.dll InvalidArrayIndex_CRASH xpcom/ds/nsTArray.cpp:28
1 xul.dll nsMsgFilterAfterTheFact::ApplyFilter comm/mailnews/search/src/nsMsgFilterService.cpp:992
2 xul.dll nsMsgSearchSession::NotifyListenersDone comm/mailnews/search/src/nsMsgSearchSession.cpp:467
3 xul.dll static nsMsgSearchSession::TimerCallback comm/mailnews/search/src/nsMsgSearchSession.cpp:410
4 xul.dll nsTimerImpl::Fire xpcom/threads/nsTimerImpl.cpp:618
5 xul.dll nsTimerEvent::Run xpcom/threads/TimerThread.cpp:248
6 xul.dll mozilla::RunnableTask::Run xpcom/threads/TaskController.cpp:502
7 xul.dll mozilla::TaskController::DoExecuteNextTaskOnlyMainThreadInternal xpcom/threads/TaskController.cpp:805
8 xul.dll mozilla::TaskController::ExecuteNextTaskOnlyMainThreadInternal xpcom/threads/TaskController.cpp:641
9 xul.dll mozilla::TaskController::ProcessPendingMTTask xpcom/threads/TaskController.cpp:425

Comment 1

[Magnus Melin [:mkmelin]]

Looks like the whole logging should be removed here: https://searchfox.org/comm-central/rev/15a241fd84b92b74caf0b75d70ffed980b3397d1/mailnews/search/src/nsMsgFilterService.cpp#992
If it failed, I don't think [0] would be accurate. It's crashing here because the array length is 0.

Comment 2

[Ben Campbell]

(In reply to Magnus Melin [:mkmelin] from comment #1)

If it failed, I don't think [0] would be accurate. It's crashing here because the array length is 0.

Yes. It's unclear to me if having an empty array is valid at this point or not. I suspect it isn't valid - why would you ever apply a filter to an empty set of messages? I think there's something going wrong further up the chain. I'll keep poking about.

Comment 3

[Magnus Melin [:mkmelin]]

Attachment: Bug 1730389 - fix Crash in [@ InvalidArrayIndex_CRASH | nsMsgFilterAfterTheFact::ApplyFilter]. r=benc

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/b82f66318b5b
fix Crash in [@ InvalidArrayIndex_CRASH | nsMsgFilterAfterTheFact::ApplyFilter]. r=benc

Comment 5

[Magnus Melin [:mkmelin]]

Comment on attachment 9244064 [details]
Bug 1730389 - fix Crash in [@ InvalidArrayIndex_CRASH | nsMsgFilterAfterTheFact::ApplyFilter]. r=benc

[Approval Request Comment]
Crash fix, not risky.

Comment 6

[Wayne Mery (:wsmwk)]

Comment on attachment 9244064 [details]
Bug 1730389 - fix Crash in [@ InvalidArrayIndex_CRASH | nsMsgFilterAfterTheFact::ApplyFilter]. r=benc

[Triage Comment]
Approved for esr91

Comment 7

[Rob Lemley [:rjl]]

Thunderbird 91.2.1:
https://hg.mozilla.org/releases/comm-esr91/rev/0de7bb5b96a5

Comment 8

[Wayne Mery (:wsmwk)]

I can see in crash-stats there are no reports from 91.2.1, so v.fixed