1730457 - White padding in browserAction popup window

Status: VERIFIED FIXED

(Thunderbird :: Add-Ons: General, defect)

Description

[juraj.masiar]

Attachment: Screenshot 2021-09-13 10.34.57.png

User Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:93.0) Gecko/20100101 Firefox/93.0

Steps to reproduce:

1. install one of these two addons:
   https://addons.thunderbird.net/en-US/thunderbird/addon/web_translate/
   https://addons.thunderbird.net/en-US/thunderbird/addon/scroll_anywhere/
2. click the toolbar icon

Actual results:

Window is opened with a strange white padding

Expected results:

There should be no additional padding.
This is a regression, but I can't remember when, exactly, something around 91. I was not reporting it sooner because I thought someone must already noticed it.

I'm author of these addons and I've released some of them also in Firefox, Chrome and Safari where no padding is added.

Comment 1

[WaltS48 [:walts48]]

I installed Web Translate in my 78.14.0, 91.1.0 and 93.0b1 on Fedora 34 Workstation, Gnome 40 desktop using the OS Adwaita-dark theme with the Thunderbird System theme.

Did not see the padding in TB 78.14.0, but do in 91.1.0 and 93.0b3.

I also noticed that the dialog window has square corners in 78.14.0, while they are rounded in 91.1.0 and 93.0b1 on my system.
Kind of like it better with the padding.

Comment 2

[WaltS48 [:walts48]]

Attachment: Web Translate.png

Enabled the extensions Dark mode.

Comment 3

[John Bieling]

This is part of the new Proton(?) design. The round corners are part of the main UI and the popup browser is loaded inside of the white frame. Extensions have no way to style it.

What I would like to change instead of removing the padding:

• make the popup theme aware, so the padding has the same background color like the backgound of the install-add-on-confirmation popup (and maybe even the little 1px grey border)
• make the default background color of the popup also follow the theme.

That still requires the add-on developers to adapt, but it will give them better integration. How does that sound?

Comment 4

[juraj.masiar]

Attachment: Firefox Proton

Well, I would like it to stay in sync with Firefox, Chrome and Safari, so that I don't have to write browser specific code :).
Also, as you can see, I'm a fan of gradient colors, so styling the padding separately would be pretty challenging, if even possible?

I've noticed the round corners in Firefox Proton, but the padding there is only 1px, so it's not that bad.

Comment 5

[John Bieling]

Oh, ok, we should definitely adjust the width of the padding to match Firefox. I was not aware of that.

Comment 6

[John Bieling]

Attachment: Bug 1730457 - Remove extra padding from WebExtension BrowserAction popup windows. r=darktrojan

Depends on D126680

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/ee7e6ff28c6a
Remove extra padding from WebExtension BrowserAction popup windows. r=darktrojan

Comment 8

[John Bieling]

Can you verify it is fixed in daily? (It is for me)

Comment 9

[juraj.masiar]

Tested in 94.0a1 (2021-09-28) (64-bit), works as expected.
Thank you :)

Comment 10

[John Bieling]

Comment on attachment 9243107 [details]
Bug 1730457 - Remove extra padding from WebExtension BrowserAction popup windows. r=darktrojan

[Approval Request Comment]
Regression caused by (bug #):
User impact if declined:
Ugly padding in action popups.

Testing completed (on c-c, etc.):
Risk to taking this patch (and alternatives if risky):
Low.

Comment 11

[Wayne Mery (:wsmwk)]

Comment on attachment 9243107 [details]
Bug 1730457 - Remove extra padding from WebExtension BrowserAction popup windows. r=darktrojan

[Triage Comment]
Approved for esr91

Comment 12

[Rob Lemley [:rjl]]

Thunderbird 91.2.1:
https://hg.mozilla.org/releases/comm-esr91/rev/f516e221dedf