1730476 - [Wayland] Use wl_output screen getter workaround on Gnome/mutter only

Status: RESOLVED FIXED

(Core :: Widget: Gtk, defect, P2)

Description

[Martin Stránský [:stransky] (ni? me)]

Use wl_output screen getter workaround on Gnome/mutter only as it causes issues to Sway compositor (https://github.com/swaywm/sway/issues/6426)

Comment 1

[Martin Stránský [:stransky] (ni? me)]

Attachment: Bug 1730476 [Wayland] Use wl_output screen getter workaround on Gnome/mutter only, r?jhorak

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/3b856ecc00e4
[Wayland] Use wl_output screen getter workaround on Gnome/mutter only, r=jhorak

Comment 3

[Martin Stránský [:stransky] (ni? me)]

We should backport that to 93.

Comment 4

[rpigott]

Gdk properly ignores these now: https://gitlab.gnome.org/GNOME/gtk/-/merge_requests/3941. This should fix the duplicate enter situation as observed here: https://github.com/swaywm/sway/issues/6426#issuecomment-911328803 on all platforms. Of course with older versions of Gdk this may still be helpful.

Comment 5

[Marian-Vasile Laza]

https://hg.mozilla.org/mozilla-central/rev/3b856ecc00e4

Comment 6

[Martin Stránský [:stransky] (ni? me)]

Comment on attachment 9240876 [details]
Bug 1730476 [Wayland] Use wl_output screen getter workaround on Gnome/mutter only, r?jhorak

Beta/Release Uplift Approval Request

• User impact if declined: Wayland Sway users can't open any popup.
• Is this code covered by automated tests?: No
• Has the fix been verified in Nightly?: No
• Needs manual test from QE?: No
• If yes, steps to reproduce:
• List of other uplifts needed: None
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): Remove introduced workaround and fall back to previous version - there isn't any risk here.
• String changes made/needed:

Comment 7

[Pascal Chevrel:pascalc (PTO until April 26)]

Comment on attachment 9240876 [details]
Bug 1730476 [Wayland] Use wl_output screen getter workaround on Gnome/mutter only, r?jhorak

Low risk fix for a new regression in 93 for some Linux users, approved for 93 beta 5, thanks!

Comment 8

[Pascal Chevrel:pascalc (PTO until April 26)]

https://hg.mozilla.org/releases/mozilla-beta/rev/e54a7ed27794