Closed Bug 1730490 Opened 3 years ago Closed 3 years ago

Add NewStringCopyN functions taking mozilla::Span and std::string_view

Categories

(Core :: JavaScript Engine, enhancement)

enhancement

Tracking

()

RESOLVED FIXED
94 Branch
Tracking Status
firefox94 --- fixed

People

(Reporter: anba, Assigned: anba)

Details

Attachments

(2 files)

For the unified Intl API work (bug 1686965), we're adding lots of new functions returning mozilla::Span and std::string_view. It'd be nice if we could directly pass these values to NewStringCopyN instead of having to pass the pointer and length separately.

And then update callers to use this new function.

And then update callers to use this new function.

Depends on D125396

Attachment #9240896 - Attachment description: Bug 1730490 - Part 1: Add NewStringCopyN function accepting mozilla::Span. r=jonco! → Bug 1730490 - Part 1: Add NewStringCopy function accepting mozilla::Span. r=jonco!
Attachment #9240897 - Attachment description: Bug 1730490 - Part 2: Add NewStringCopyN function accepting std::basis_string_view. r=jonco! → Bug 1730490 - Part 2: Add NewStringCopy function accepting std::basis_string_view. r=jonco!
Pushed by andre.bargull@gmail.com:
https://hg.mozilla.org/integration/autoland/rev/4a8b530bdce2
Part 1: Add NewStringCopy function accepting mozilla::Span. r=jonco
https://hg.mozilla.org/integration/autoland/rev/11dde9993630
Part 2: Add NewStringCopy function accepting std::basis_string_view. r=jonco
Status: ASSIGNED → RESOLVED
Closed: 3 years ago
Resolution: --- → FIXED
Target Milestone: --- → 94 Branch
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: