Closed Bug 1730504 Opened 1 year ago Closed 1 year ago

Refactor the OOM testing framework a little

Categories

(Core :: JavaScript Engine, task, P3)

task

Tracking

()

RESOLVED FIXED
94 Branch
Tracking Status
firefox94 --- fixed

People

(Reporter: jonco, Assigned: jonco)

References

(Blocks 1 open bug)

Details

Attachments

(5 files)

Currently the OOM testing framework is implemented by one large function, RunIterativeFailureTest. This could be split up to make it easier to understand.

This adds an IterativeFailureTest class which encompasses the current testing
framework with the testing code in a 'test' method.

This splits the method up into several sub-methods to make it easier to see
what's going on.

Depends on D125400

It's possible to compile OOM testing facilites outside of debug builds with the
--enable-oom-breakpoint flag so the test should work in that case too.

Depends on D125401

Pushed by jcoppeard@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/edad8fb2acb7
Refactor iterative failure test framework into a class r=tcampbell
https://hg.mozilla.org/integration/autoland/rev/e807fc5c74a7
Split up IterativeFailureTest::test method into separate methods r=tcampbell
https://hg.mozilla.org/integration/autoland/rev/fae38e9e15b1
Make OOM tests work outside debug builds r=tcampbell
https://hg.mozilla.org/integration/autoland/rev/8ee862840f12
Make ParseIterativeFailureTestParams into a method on IterativeFailureTest r=tcampbell
https://hg.mozilla.org/integration/autoland/rev/ccd492a6bd67
Remove IterativeFailureTest::Params class and store fields directly in the class r=tcampbell
You need to log in before you can comment on or make changes to this bug.