1730504 - Refactor the OOM testing framework a little

Status: RESOLVED FIXED

(Core :: JavaScript Engine, task, P3)

Description

[Jon Coppeard (:jonco)]

Currently the OOM testing framework is implemented by one large function, RunIterativeFailureTest. This could be split up to make it easier to understand.

Comment 1

[Jon Coppeard (:jonco)]

Attachment: Bug 1730504 - Refactor iterative failure test framework into a class r?tcampbell

This adds an IterativeFailureTest class which encompasses the current testing
framework with the testing code in a 'test' method.

Comment 2

[Jon Coppeard (:jonco)]

Attachment: Bug 1730504 - Split up IterativeFailureTest::test method into separate methods r?tcampbell

This splits the method up into several sub-methods to make it easier to see
what's going on.

Depends on D125400

Comment 3

[Jon Coppeard (:jonco)]

Attachment: Bug 1730504 - Make OOM tests work outside debug builds r?tcampbell

It's possible to compile OOM testing facilites outside of debug builds with the
--enable-oom-breakpoint flag so the test should work in that case too.

Depends on D125401

Comment 4

[Jon Coppeard (:jonco)]

Attachment: Bug 1730504 - Make ParseIterativeFailureTestParams into a method on IterativeFailureTest r?tcampbell

Depends on D125402

Comment 5

[Jon Coppeard (:jonco)]

Attachment: Bug 1730504 - Remove IterativeFailureTest::Params class and store fields directly in the class r?tcampbell

Depends on D125513

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/edad8fb2acb7
Refactor iterative failure test framework into a class r=tcampbell
https://hg.mozilla.org/integration/autoland/rev/e807fc5c74a7
Split up IterativeFailureTest::test method into separate methods r=tcampbell
https://hg.mozilla.org/integration/autoland/rev/fae38e9e15b1
Make OOM tests work outside debug builds r=tcampbell
https://hg.mozilla.org/integration/autoland/rev/8ee862840f12
Make ParseIterativeFailureTestParams into a method on IterativeFailureTest r=tcampbell
https://hg.mozilla.org/integration/autoland/rev/ccd492a6bd67
Remove IterativeFailureTest::Params class and store fields directly in the class r=tcampbell

Comment 7

[Andreea Pavel [:apavel]]

https://hg.mozilla.org/mozilla-central/rev/edad8fb2acb7
https://hg.mozilla.org/mozilla-central/rev/e807fc5c74a7
https://hg.mozilla.org/mozilla-central/rev/fae38e9e15b1
https://hg.mozilla.org/mozilla-central/rev/8ee862840f12
https://hg.mozilla.org/mozilla-central/rev/ccd492a6bd67