Closed
Bug 1730595
Opened 3 years ago
Closed 3 years ago
nsDOMOfflineResourceList.cpp:51:19: warning: unused variable 'kMaxEntriesPref' [-Wunused-const-variable]
Categories
(Core :: DOM: Core & HTML, task)
Core
DOM: Core & HTML
Tracking
()
RESOLVED
FIXED
94 Branch
| Tracking | Status | |
|---|---|---|
| firefox94 | --- | fixed |
People
(Reporter: dholbert, Assigned: dholbert)
Details
Attachments
(1 file)
Noticed this build warning, when building with --disable-unified-build:
dom/offline/nsDOMOfflineResourceList.cpp:51:19: warning: unused variable 'kMaxEntriesPref' [-Wunused-const-variable]
static const char kMaxEntriesPref[] = "offline.max_site_resources";
Indeed, this variable seems to be unused (and seems to be the only reference to offline.max_site_resources in our codebase). Presumably this pref isn't supported/meaningful anymore:
https://searchfox.org/mozilla-central/search?q=symbol:_ZL15kMaxEntriesPref&redirect=false
Let's remove the unused variable.
|
Assignee | |
Updated•3 years ago
|
Component: DOM: Web Crypto → DOM: Core & HTML
|
|
Assignee | |
Comment 1•3 years ago
|
||
The following two defines are also unused, too, so I'll get rid of those while I'm here.
|
|
Assignee | |
Comment 2•3 years ago
|
||
...and the various #define ..._STR that are before this section seem to be unused, as well.
|
|
Assignee | |
Comment 3•3 years ago
|
||
Pushed by dholbert@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/beaa29229ad1 Remove unused constants from nsDOMOfflineResourceList.cpp. r=mccr8
|
||
Comment 5•3 years ago
|
||
| bugherder | ||
Status: NEW → RESOLVED
Closed: 3 years ago
Resolution: --- → FIXED
Target Milestone: --- → 94 Branch
You need to log in
before you can comment on or make changes to this bug.
Description
•