HCM incorrectly backplates when using semi-transparent system colors
Categories
(Core :: Layout, defect)
Tracking
()
| Tracking | Status | |
|---|---|---|
| firefox94 | --- | fixed |
People
(Reporter: morgan, Assigned: emilio)
References
Details
(Keywords: access, Whiteboard: [hcm-2021-h2])
Attachments
(1 file)
Currently in about:preferences on MacOS, when HCM is enabled buttons render as white text on a white backplate. This is because the system color we use for button backgrounds is semi-transparent white, which gets "forced" to opaque white when we climb the frame tree looking for a backplate color.
|
Assignee | |
Comment 1•3 years ago
|
||
This should ensure the correct behavior when system colors are
semi-transparent, like on macOS on dark mode.
Testing this without hard-coding the system color seems hard (and I
think macOS on automation might not even hard native dark mode support
anyways).
In fact, if it did I think backplat-bg-image-006 would've caught it.
|
||
Updated•3 years ago
|
Pushed by ealvarez@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/07cc0233e347 Blend with ancestor backgrounds until we compute an opaque backplate color. r=morgan
Pushed by emilio@crisal.io: https://hg.mozilla.org/integration/autoland/rev/13b542ebd739 Use standins if forced to in nsNativeBasicTheme.
Pushed by ccozmuta@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/15b1fe3aa4d0 Fix reftest failures.r=emilio. CLOSED TREE
|
||
Comment 5•3 years ago
|
||
| bugherder | ||
https://hg.mozilla.org/mozilla-central/rev/07cc0233e347
https://hg.mozilla.org/mozilla-central/rev/13b542ebd739
https://hg.mozilla.org/mozilla-central/rev/15b1fe3aa4d0
|
Reporter | |
Updated•3 years ago
|
|
||
Updated•11 months ago
|
Description
•