1730626 - TypeError: '<' not supported between instances of 'bool' and 'StrictVersion' when running mach lint

Status: RESOLVED FIXED

(Developer Infrastructure :: Lint and Formatting, task)

Description

[Emilio Cobos Álvarez (:emilio)]

./mach lint --warnings --outgoing --fix                                                                                                                                                                                                 
error: problem with lint setup, skipping android-api-lint, android-checkstyle, android-javadoc, android-lint, android-test
Traceback (most recent call last):
  File "/home/emilio/src/moz/gecko-4/python/mozlint/mozlint/roller.py", line 66, in _run_worker
    res = func(paths, config, **lintargs)
  File "/home/emilio/src/moz/gecko-4/python/mozlint/mozlint/types.py", line 57, in __call__
    return self._lint(paths, config, **lintargs)
  File "/home/emilio/src/moz/gecko-4/python/mozlint/mozlint/types.py", line 148, in _lint
    return func(files, config, **lintargs)
  File "/home/emilio/src/moz/gecko-4/tools/lint/clippy/__init__.py", line 182, in lint
    if actual_version < min_version:
TypeError: '<' not supported between instances of 'bool' and 'StrictVersion'

Comment 1

[Emilio Cobos Álvarez (:emilio)]

$ rustup component add clippy helped. So probably we should either install that by default or fail gracefully.

Comment 2

[Andrew Halberstadt [:ahal]]

Attachment: Bug 1730626 - [lint] Print proper error message when clippy is not installed, r?#linter-reviewers

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/54f353951327
[lint] Print proper error message when clippy is not installed, r=linter-reviewers,marco

Comment 4

[Cristina Cozmuta (:CrissCozmuta)]

https://hg.mozilla.org/mozilla-central/rev/54f353951327