1730635 - Add tests of CalDAV/CardDAV discovery using DNS

Status: RESOLVED FIXED

(Thunderbird :: Address Book, task)

Description

[Geoff Lankow (:darktrojan)]

We use DNS to find calendars and address books. There should be tests of this but until recently I hadn't figured out how to do it.

Comment 1

[Geoff Lankow (:darktrojan)]

Attachment: Bug 1730635 - Add tests of CalDAV/CardDAV discovery using DNS. r=mkmelin

These tests hijack the DNS module's functions to return the intended result.

We can't use the mock servers for the tests because we only do discovery for HTTPS, and the mock servers can't speak HTTPS. Instead, we direct the code to some files on the Mochitest server.

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/aee118489a59
Add tests of CalDAV/CardDAV discovery using DNS. r=mkmelin

Comment 3

[Magnus Melin [:mkmelin]]

Looks like calendar/test/browser/browser_calDAV_discovery.js has been permafailing on win32 since this landed.

Comment 4

[Rob Lemley [:rjl]]

Comment on attachment 9241051 [details]
Bug 1730635 - Add tests of CalDAV/CardDAV discovery using DNS. r=mkmelin

[Triage Comment]
Test changes; needed for bug 1732565 to apply cleanly.

Comment 5

[Rob Lemley [:rjl]]

Thunderbird 91.3.0:
https://hg.mozilla.org/releases/comm-esr91/rev/b3632db96905

Comment 6

[Geoff Lankow (:darktrojan)]

Attachment: Bug 1730635 and bug 1732565 - Fix tests for ESR91. r=rjl

Bug 1683865 changed some elements from XUL to HTML and this behaves differently in the test.

Comment 7

[Rob Lemley [:rjl]]

Thunderbird 91.3.0+:
https://hg.mozilla.org/releases/comm-esr91/rev/b54853f8a66c49cd0a7a1c6149c436b8078f8a66