"Open previous windows and tabs" not working
Categories
(Firefox :: Session Restore, defect)
Tracking
()
People
(Reporter: james.redfern, Unassigned)
References
Details
Attachments
(3 files)
Screen Shot of "Open previous windows and tabs"
User Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:94.0) Gecko/20100101 Firefox/94.0
Steps to reproduce:
Close the browser.
Actual results:
Confirmation to close all tabs is presented.
Expected results:
Browser should have closed without closing tabs.
|
Reporter | |
Comment 1•4 years ago
|
||
94.0a1 (2021-09-13) (64-bit)
issue has remained in several updates
|
||
Comment 2•4 years ago
|
||
The Bugbug bot thinks this bug should belong to the 'Firefox::Tabbed Browser' component, and is moving the bug to that component. Please revert this change in case you think the bot is wrong.
|
||
Comment 3•4 years ago
|
||
Hello! I have managed to reproduce the issue using firefox 94.0a1(2021-09-16), 93.0b5 and 92.0 on macOS 10.15.
I have enabled session restore and the check box to warn me when closing multiple tabs. Indeed when pressing the x button and opening firefox again from the dock the tabs are not restored, however when you press quit firefox and open it again the previous session and all the tabs are restored.
I will mark this issue as new and set it to a component in order for our developers to look more into it. If it's not the right component please feel free to change it to the appropriate one.
Thank you and have a nice day!
|
|
||
Updated•4 years ago
|
Expected results:
Browser should have closed without closing tabs.
Can you clarify what this means? It's unclear to me what it means for the browser to close without closing tabs.
Nevertheless, this sounds related to the bug 1724959 work and the findings in bug 1724370 comment #32.
|
|
Reporter | |
Comment 5•4 years ago
|
||
Rephrase as "Browser should have Quit without closing tabs."
The "Open previous windows and tabs" is checked under Startup.
And "Confirm before closing multiple tabs" is checked in dialog "Close <x> tabs?".
Must click "Cancel" button to avoid closing saved tabs, and browser does not quit.
|
|
Reporter | |
Comment 6•4 years ago
|
||
|
|
Reporter | |
Comment 7•4 years ago
|
||
Ah, okay, I understand. There's ongoing work to fix the flow here. Follow bug 1724959.
|
|
Reporter | |
Comment 9•4 years ago
|
||
The defect is now worse on Nightly 94.0a1 (2021-09-20) (64-bit).
Clicking the red circle to close the window now closes all multiple tabs without a confirmation, even though "Confirm before closing multiple tabs" is checked.
Starting Nightly again does not open previous tabs even though "Open previous window and tabs" is checked.
All previous tabs have been lost.
|
|
Reporter | |
Comment 10•4 years ago
|
||
|
||
Comment 11•4 years ago
|
||
Neil can you take a look? This appears to be related to the MR1.1 "close multiple tabs" work.
|
||
Comment 12•4 years ago
|
||
The comments here seem to contradict each other and don't make it clear what the bug is.
On Mac, pressing the red close button should display a warning if 'Confirm before closing multiple tabs' is checked. If you press 'Close tabs' in that warning dialog, the window should close and Firefox should not quit. If you then quit firefox, and restart, the windows and tabs are not restored. But you can select 'Recently Closed Windows' from the History menu to open them again.
If 'Confirm before closing multiple tabs' is not checked, then the window should close and Firefox should not quit when pressing the window close button, but no warning should appear.
If you instead quit Firefox from the file menu or press Command+Q then any open windows will be restored when you restart.
|
||
Comment 13•4 years ago
|
||
I agree with Neil, it's unclear what the issue is meant to be here, but broadly things sound like they work as expected. Especially now that bug 1724977 has landed, I would expect that this is resolved. If not, we need a much crisper description of what the problem is, and we can reopen and investigate.
Description
•