1730699 - Optimize for-in with null/undefined better

Status: RESOLVED FIXED

(Core :: JavaScript Engine, task, P3)

Description

[Jan de Mooij [:jandem]]

for-in loops on null/undefined are somewhat common. Speedometer hits this too. We have some performance problems:

• We allocate a new empty iterator for this each time, instead of reusing the same iterator object.
• We don't have CacheIR support for this case. This can result in disabling the IC if this shows up a few times.

A patch stack to fix these issues improves the micro-benchmark below from 220 ms to 5 ms.

function f() {
  var t = new Date;
  for (var i = 0; i < 1_000_000; i++) {
    for (var p in undefined) {}
  }
  print(new Date - t);
}
f();

Comment 1

[Jan de Mooij [:jandem]]

Attachment: Bug 1730699 part 1 - Treat empty iterators for null/undefined as immutable and unlinked. r?jonco!

This changes the empty iterator objects we create for for-in with null/undefined
to be immutable and unlinked.

The next patch will cache this object on the global.

Comment 2

[Jan de Mooij [:jandem]]

Attachment: Bug 1730699 part 2 - Cache empty iterator on the global. r?jonco!

Depends on D125551

Comment 3

[Jan de Mooij [:jandem]]

Attachment: Bug 1730699 part 3 - Clean up CacheIR code for GetIterator a bit. r?jonco!

Depends on D125552

Comment 4

[Jan de Mooij [:jandem]]

Attachment: Bug 1730699 part 4 - Add CacheIR optimization for GetIterator with null/undefined. r?jonco!

Depends on D125553

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/c7eae2ddd714
part 1 - Treat empty iterators for null/undefined as immutable and unlinked. r=jonco
https://hg.mozilla.org/integration/autoland/rev/cab0e02d59e1
part 2 - Cache empty iterator on the global. r=jonco
https://hg.mozilla.org/integration/autoland/rev/48465af484b5
part 3 - Clean up CacheIR code for GetIterator a bit. r=jonco
https://hg.mozilla.org/integration/autoland/rev/8a9d97b273e7
part 4 - Add CacheIR optimization for GetIterator with null/undefined. r=jonco

Comment 6

[Marian-Vasile Laza]

https://hg.mozilla.org/mozilla-central/rev/c7eae2ddd714
https://hg.mozilla.org/mozilla-central/rev/cab0e02d59e1
https://hg.mozilla.org/mozilla-central/rev/48465af484b5
https://hg.mozilla.org/mozilla-central/rev/8a9d97b273e7