173077 - print preview of nothing tried to create a window

Status: VERIFIED WORKSFORME

(MailNews Core :: Printing, defect, P1)

Description

[timeless]

doron tested this using his untarnished mailnews client. 

the steps:
1. open mailnews to a folder
2. scroll to the very end of the thread pane and size the pane so that you can
see some whitespace
3. select a message in the thread pane
4. ctrl-click it to deselect it (problems start here)
5. right click whitespace in the threadpane (be sure not to click on a row that
has a message)
5' print preview was enabled - bug 173074
6. click print preview
6' nothing really happens
7. click the window menu
7' see a blank numbered window entry

What should we do? well, i'd kind of like print preview not to create bogus windows.

Comment 1

[timeless]

(yes these aren't really valid dependencies, but if you fix things one way the
problems will disappear...)

Comment 2

[Steve Chapel]

Attachment: first try at fix

This patch works -- when you select Print Preview with no messages selected, no
bogus windows are created, and further, no JS errors or warnings are produced
(that is, if bug 191158 is fixed). But the patch seems like a hack. Maybe we
should just fix bug 173074 and be done with it.

Comment 3

[Wayne Mery (:wsmwk)]

is this still a problem now that bug 173074 is fixed?

Comment 4

[Steve Simms]

Unable to reproduce in 2.0.0.16 on WinXP (Print Preview is disabled in the context menu), so I'm guessing it was fixed as per the previous comment.

Comment 5

[Wayne Mery (:wsmwk)]

v. WFM on trunk thunderbird