1730812 - mipsel64 build failure from bug 1709303

Status: RESOLVED FIXED

(Core :: Graphics: ImageLib, defect, P2)

Description

[Mike Hommey [:glandium]]

clang-12: error: unknown argument: '-mloongson-ext'
clang-12: error: unsupported argument '-mloongson-mmi' to option 'Wa,'

See https://phabricator.services.mozilla.com/D125458#4078500

Comment 1

[BugBot [:suhaib / :marco/ :calixte]]

Set release status flags based on info from the regressing bug 1709303

Comment 2

[Brad Werth [:bradwerth]]

Looks like one of the review issues for Bug 1709303 didn't get addressed before landing. Andrew, can you fix this up?

Comment 3

[Mike Hommey [:glandium]]

I commented there after it landed, but it could be argued it should have gone through the build peers in the first place.

Comment 4

[Andrew Osmond [:aosmond] (he/him)]

It seems I missed the compiler check:

https://github.com/libjpeg-turbo/libjpeg-turbo/blob/main/simd/CMakeLists.txt#L364

I was very careful with the NEON checks since they were complicated, but I was careless with MIPS.

Comment 5

[Andrew Osmond [:aosmond] (he/him)]

Attachment: Bug 1730812 - Check for loongson mmi support in mips64 build for libjpeg-turbo.

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/0ef43ef362e6
Check for loongson mmi support in mips64 build for libjpeg-turbo. r=aosmond

Comment 7

[Andreea Pavel [:apavel]]

https://hg.mozilla.org/mozilla-central/rev/0ef43ef362e6

Comment 8

[Ryan VanderMeulen [:RyanVM]]

Did you want to nominate this for Beta uplift?

Comment 9

[Andrew Osmond [:aosmond] (he/him)]

I don't think it is critical.