1730876 - Sponsored Suggestions are not displayed for a keyword after it was clicked twice

Status: VERIFIED FIXED

(Firefox :: Address Bar, defect, P1)

Description

[Maria Heres, inactive, contact Ecosystem QA]

Attachment: hublot 2.gif

[Affected Versions]:

• FIrefox Beta 93.0b5 (Build ID: 20210914185637)
• Firefox Nightly 94.0a1 (Build ID: 20210915092453)

[Affected Platforms]:

• Windows 10
• Linux Mint 20
• macOS 11.1

[Prerequisites]:

• Have Firefox en-US ver 93 installed and opened.
• Be in the US (or use a VPN / set “browser.search.region” to “US”)

[Steps to reproduce]:

1. Focus the awesomebar and type a keyword (e.g. “hublot “).
2. Click the sponsored Firefox Suggest result.
3. Open a new tab and repeat steps 1 and 2.
4. Open a new tab and focus the awesomebar.
5. Type the keyword again (i.e. “hublot “) and observe the suggestions displayed.

[Expected result]:

• The sponsored suggestion is displayed when a keyword is used.

[Actual result]:

• The sponsored suggestion is displayed twice and then it is no longer displayed - only the history version is displayed.

[Notes]:

• Attached is a screen recording of the issue.

Comment 1

[Drew Willcoxon :adw]

Nice catch, thank you Maria.

The muxer is de-deduping (removing) the Fx Suggest suggestion because its URL is the same as the one from history.

Comment 2

[Drew Willcoxon :adw]

Attachment: Bug 1730876 - Never discard quick suggest results and dedupe other URL results with a lower or same prefix rank.

This makes a couple of changes:

• Never discard suggestedIndex results. At some point we may want to revisit,
  but right now in all our use cases for suggestedIndex, we should never discard
  them.
• Discard non-suggestedIndex URL results whose URLs dupe the URLs of
  suggestedIndex results or whose URLs have a lower prefix rank.

The first change by itself fixes the bug, but without the second change, we'll
still show the eBay history result above the eBay Firefox Suggest result, which
I don't think is what we want. We only want to show the Firefox Suggest one.

Keep in mind that the results in this case have the same URLs, same prefixes.
However, when a non-suggestedIndex result has a higher prefix rank, I think we
should not discard it. In that case we should show both the suggestedIndex
result with its lower prefix rank and the other result with its higher rank.

Comment 4

[Drew Willcoxon :adw]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=3f9f4d8f9fef8b89a7a253a8a6cce465be37075a

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/54b20adae193
Never discard quick suggest results and dedupe other URL results with a lower or same prefix rank. r=mak

Comment 6

[Cristina Cozmuta (:CrissCozmuta)]

https://hg.mozilla.org/mozilla-central/rev/54b20adae193

Comment 7

[Carmen Fat [:cfat] - Ecosystem QA]

• I have verified this issue using the latest Nightly 94.0a1 (Build ID: 20210917093507) build on Windows 10 x64, macOS 11.6 and Linux Ubuntu 20.04 x64.
• The sponsored suggestions are displayed when typing the keyword in the Address Bar, even if they were previously clicked several times.

Comment 8

[Drew Willcoxon :adw]

Comment on attachment 9241472 [details]
Bug 1730876 - Never discard quick suggest results and dedupe other URL results with a lower or same prefix rank.

Beta/Release Uplift Approval Request

• User impact if declined: Needed for important Firefox Suggest rollouts on 93 and 92
• Is this code covered by automated tests?: Yes
• Has the fix been verified in Nightly?: Yes
• Needs manual test from QE?: Yes
• If yes, steps to reproduce: Please see comment 0
• List of other uplifts needed: None
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): This is a small fix that only applies to Firefox Suggest suggestions.
• String changes made/needed:

Comment 9

[Ryan VanderMeulen [:RyanVM]]

Comment on attachment 9241472 [details]
Bug 1730876 - Never discard quick suggest results and dedupe other URL results with a lower or same prefix rank.

Approved for 93.0b7.

Comment 10

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-beta/rev/ab6587daa421

Comment 11

[Carmen Fat [:cfat] - Ecosystem QA]

• I have verified this issue using the latest Beta 93.0b7 (Build ID: 20210919190049) build on Windows 10 x64, macOS 11.6 and Linux Ubuntu 20.04 x64.
• The sponsored suggestions are displayed when typing the keyword in the Address Bar, even if they were previously clicked several times.

Comment 12

[Ryan VanderMeulen [:RyanVM]]

Comment on attachment 9241472 [details]
Bug 1730876 - Never discard quick suggest results and dedupe other URL results with a lower or same prefix rank.

Approved for 92.0.1.

Comment 13

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-release/rev/3da3592431fe

Comment 14

[Carmen Fat [:cfat] - Ecosystem QA]

• I have verified this issue using the Candidate 92.0.1 build (Build ID: 20210920202613) on Windows 10 x64, macOS 10.15.7 and Linux Ubuntu 20.04 x64.

• The sponsored suggestions are displayed when typing the keyword in the Address Bar, even if they were previously clicked several times.