1730880 - Some Quick Suggest suggestions are inconsistent

Status: RESOLVED WORKSFORME

(Firefox :: Address Bar, defect, P3)

Description

[Maria Heres, inactive, contact Ecosystem QA]

Attachment: pilot.gif

[Affected Versions]:

• FIrefox Beta 93.0b5 (Build ID: 20210914185637)
• Firefox Nightly 94.0a1 (Build ID: 20210915092453)

[Affected Platforms]:

• Windows 10
• Linux Mint 20
• macOS 11.1

[Prerequisites]:

• Have Firefox en-US ver 93 installed and opened.
• Be in the US (or use a VPN / set “browser.search.region” to “US”)

[Steps to reproduce]:

1. Focus the awesomebar and type “iwc ”.
2. Add “pilot” to that string.
3. Observe the suggestion displayed.

[Expected result]:

• The “iwc pilot” suggestion is displayed for the second string.

[Actual result]:

• While the first string triggers the “iwc pilot” suggestion, the second does not.

[Notes]:

• The Luxury Watches suggestion also seems to not display its suggestion for a string like “best watches for m” but it does for “best watches for me”.
• Attached is a screen recording of the issue.

Comment 1

[Drew Willcoxon :adw]

This is related to the keywords in the AdM dataset. It's not a bug in the code, but it is something we may want to think about or investigate on the dataset side. I'm still not clear on whether we generate keywords ourselves or use ones provided as-is from AdM. If the latter (which I think is the case?), then there may not be much we can do here. Dale, what do you think?

Regardless, this doesn't block the offline/online rollouts unless Natalie thinks it should, but that would be surprising because this has always been the behavior of Fx Suggest/quick suggest.

We purposely do exact keyword matching in the code. Each suggestion has a set of keywords, and your search string must exactly match one of the keywords to trigger the suggestion.

I looked up the keywords for this suggestion and they are:

"iwc"
"iwc "
"iwc pilot w"
"iwc pilot wa"
"iwc pilot wat"
"iwc pilot watc"
"iwc pilot watch"
"iwc pilot watche"
"iwc pilot watches"
"iwc po"
"iwc por"
"iwc port"
"iwc portu"
"iwc portug"
"iwc portugu"
"iwc portugue"
"iwc portugues"
"iwc portuguese"
"iwc w"
"iwc wa"
"iwc wat"
"iwc watc"
"iwc watch"
"iwc watche"
"iwc watches"

There are "iwc" and "iwc " (trailing space) keywords but nothing else that includes the first part of "iwc pilot".

Comment 2

[Drew Willcoxon :adw]

I've confirmed the keywords are determined by adM and we don't change them, so there's nothing we can really do here in terms of engineering. We could maybe bring it up with adM. Since this is working as intended, I'll close it.