Closed Bug 1731012 Opened 3 years ago Closed 2 years ago

Sometimes PLDHashTable is falsely blamed for test failures.

Categories

(Core :: XPCOM, defect)

Product:
Core
Component:
XPCOM
Type:
defect

Tracking

()

Status:
RESOLVED FIXED
Milestone:
107 Branch
Tracking Flags:
Tracking Status
firefox107 --- fixed

People

(Reporter: pbone, Assigned: glandium, NeedInfo)

References

Details

Attachments

(1 file)

Bug 1731012 - Avoid PLDHashTable crash tests printing their confusing crash output.
48 bytes, text/x-phabricator-request
Details | Review

Test failures like this

https://treeherder.mozilla.org/jobs?repo=try&revision=3465b6abb51c543b26da134b4c477203c83e532e&selectedTaskRun=UPHE9_SzQtOHFewTyp56ig.0

Are falsely detected as being related to the PLDHashTable tests, which test than an expected crash does occur. The real failure is here: https://treeherder.mozilla.org/logviewer?job_id=351651425&repo=try&lineNumber=7464

Could the crashes in PLDHashTableTest get detected but printing Hit MOZ_CRASH be avoided? Treeherder can look for that pattern or ignore it.

Flags: needinfo?(pbone)
Component: Treeherder: Log Parsing & Classification → TreeHerder

:pbone, can you please respond to the Aryx's query please so this bug can get resolved?

Assignee: nobody → mh+mozilla
Component: Treeherder → XPCOM
Product: Tree Management → Core
Version: --- → unspecified
Pushed by mh@glandium.org:
https://hg.mozilla.org/integration/autoland/rev/fbb5561cb3ec
Avoid PLDHashTable crash tests printing their confusing crash output. r=xpcom-reviewers,nika

https://hg.mozilla.org/mozilla-central/rev/fbb5561cb3ec

Status: NEW → RESOLVED
Closed: 2 years ago
status-firefox107: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 107 Branch
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: