1731060 - Permanent js/src/vm/JSContext.cpp:1081:13: error: unused function 'IsOutOfMemoryException' [-Werror,-Wunused-function] when Gecko 94 merges to Beta on 2021-10-04

Status: VERIFIED FIXED

(Core :: JavaScript Engine, defect)

Description

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

• central-as-beta simulation
• How to run these simulations
• Failure log

[task 2021-09-16T12:19:21.943Z]  2:52.93 /builds/worker/checkouts/gecko/js/src/vm/JSContext.cpp:1081:13: error: unused function 'IsOutOfMemoryException' [-Werror,-Wunused-function]

Since bug 1730426 the only caller of IsOutOfMemoryException is guarded by #if defined(NIGHTLY_BUILD) https://searchfox.org/mozilla-central/rev/4d90ff4537330d6b17cb956c0fadf759086d9bb7/js/src/vm/JSContext.cpp#1083-1116

Comment 1

[Ted Campbell [:tcampbell]]

Attachment: Bug 1731060 - Guard nightly-only symbols in JSContext.cpp. r?caroline!

The IsOutOfMemoryException helper is only used by the nightly error
interceptor, so guard with an ifdef.

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/a9b76b17ba5c
Guard nightly-only symbols in JSContext.cpp. r=caroline

Comment 3

[Narcis Beleuzu [:NarcisB]]

https://hg.mozilla.org/mozilla-central/rev/a9b76b17ba5c

Comment 4

[Andreea Pavel [:apavel]]

Verified fixed in latest beta sim https://treeherder.mozilla.org/jobs?repo=try&group_state=expanded&resultStatus=testfailed%2Cbusted%2Cexception%2Crunnable&revision=1fd18a7b648dc9da254850a69101a4ea0b8a3452