Closed
Bug 1731098
Opened 3 years ago
Closed 3 years ago
TestMultiplexInputStream.cpp is missing an nsIThread #includes
Categories
(Core :: XPCOM, defect)
Core
XPCOM
Tracking
()
RESOLVED
FIXED
94 Branch
| Tracking | Status | |
|---|---|---|
| firefox94 | --- | fixed |
People
(Reporter: KrisWright, Assigned: KrisWright)
Details
Attachments
(1 file)
This can lead to build failures when building in a different unified file (e.g. adding a few new gtests to the directory)
|
Assignee | |
Comment 1•3 years ago
|
||
When adding new gtests I came across this build failure:
0:12.59 In file included from Unified_cpp_xpcom_tests_gtest2.cpp:2:
0:12.59 /home/kriswright/src/mozilla-unified/xpcom/tests/gtest/TestMultiplexInputStream.cpp:349:45: error: no viable conversion from 'nsCOMPtr<nsIThread>' to 'nsIEventTarget *'
It looks like this file needs to include nsIThread in its #includes.
|
||
Updated•3 years ago
|
Assignee: nobody → kwright
Status: NEW → ASSIGNED
Pushed by kwright@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/2e3a78b7165a Include nsIThread in TestMultiplexInputStream.cpp r=xpcom-reviewers,nika
|
||
Comment 3•3 years ago
|
||
| bugherder | ||
Status: ASSIGNED → RESOLVED
Closed: 3 years ago
status-firefox94:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 94 Branch
You need to log in
before you can comment on or make changes to this bug.
Description
•