Closed
Bug 1731108
Opened 4 years ago
Closed 4 years ago
Improve text contrast in themed address bar boxes
Categories
(Firefox :: Theme, defect, P1)
Firefox
Theme
Tracking
()
| Tracking | Status | |
|---|---|---|
| firefox94 | --- | verified |
People
(Reporter: bugzilla, Assigned: bugzilla)
References
Details
(Whiteboard: [fidefe-theme])
Attachments
(1 file)
Now that Mozilla themes can change the address bar chiclet, there are issues with text contrast. We need another new CSS variable to set the text color in the chiclet.
In the Figma specs for the new themes, the address bar chiclet always uses the toolbar text color. At first, that seemed like a reasonable default for text color in all themes. However, that doesn't work for themes where the address bar or address bar focus background is the same color as toolbar text, such as Alpenglow.
|
Assignee | |
Comment 1•4 years ago
|
||
Pushed by htwyford@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/5b6534c6d41d
Allow experimental themes to override text color in address bar chiclets. r=dao
|
|
Assignee | |
Updated•4 years ago
|
Whiteboard: [fidefe-theme]
|
|
Assignee | |
Updated•4 years ago
|
Points: 1 → 2
|
||
Comment 4•4 years ago
|
||
| bugherder | ||
Status: ASSIGNED → RESOLVED
Closed: 4 years ago
status-firefox94:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 94 Branch
|
||
Updated•4 years ago
|
Flags: qe-verify+
|
||
Updated•4 years ago
|
|
||
Comment 5•4 years ago
|
||
We verified the fix using Firefox 94.0b2 on Windows 10 x64, macOS 10.15 and Ubuntu 18.04 x64. The issue is not reproducing anymore.
You need to log in
before you can comment on or make changes to this bug.
Description
•