1731152 - Spotlight link has unexpected border in HCM mode

Status: VERIFIED FIXED

(Firefox :: Messaging System, defect, P1)

Description

[Morgan Reschenberg [:morgan]]

STR:

0. Enable High Contrast Mode in Windows settings
1. set this pref to true: browser.newtabpage.activity-stream.asrouter.devtoolsEnabled
2. navigate to about:newtab#asrouter
3. search in page for "Spotlight" and click the "Show" button associated.
4. view the popup, mouseover each button

Expected:
The "Stay protected..." button inverts on mouseover
The "Not now" button uses the user's foreground and background colors
On mouseover, the button inverts (or indicates mouseover in some other way, but remains visibly a button).

Actual:
The "Stay protected..." button changes to use the user's foreground and background colors, losing its "preferred" indication.
The button uses the user's background and hyperlink colors
On mouseover, the button loses its border, bleeds into the page, and gains underline text styling as if it were a link

Comment 1

[Punam Dahiya [:pdahiya]]

This is not blocker for experiment. This should be blocking accessibility bug for this feature. NI Dan to help with that thanks!

Comment 2

[Dan Mosedale (:dmosedale, :dmose)]

Attachment: fixed version

Comment 3

[Dan Mosedale (:dmosedale, :dmose)]

Although they are both semantically buttons, the "Not Now" thing is supposed to look and feel like a link.

Morgan just looked at the fixed version screencast that I just attached and said it looks good. I'll upload the patch that generated the above screencast shortly.

For this patch, I'm working around theme bugs just for this dialog, because I'd like it to be upliftable to 93 beta if possible. Something that does the right fixes won't be upliftable -- they will effect substantially more than just this dialog and require some discussion.

Comment 4

[Dan Mosedale (:dmosedale, :dmose)]

[Tracking Requested - why for this release]:

We'd like to have something that looks better for high-contrast themes, since if the captive portal experiment goes well, we hope to start rolling out the feature during 93 release.

Comment 5

[Dan Mosedale (:dmosedale, :dmose)]

Attachment: Bug 1731152 - Fix high-contrast mode issues with captive portal VPN promo dialog, r?Mardak

Comment 6

[Dan Mosedale (:dmosedale, :dmose)]

The QA verification for this bug is really just to make sure that it looks like the screencast attachment on Windows.

Comment 7

[Pascal Chevrel (relman team) -> :pascalc]

FYI, our last beta builds today, this needs to land asap and an uplift request. Thanks

Comment 8

[Dan Mosedale (:dmosedale, :dmose)]

After reconsidering Mardak's review comments and looking at timing, I think the better thing to do is get the right fix in after 93 rather than try and jam this workaround in at the last second. I'm going withdraw this from 93 uplift consideration and solicit feedback for the longer-term patch direction.

Comment 9

[Dan Mosedale (:dmosedale, :dmose)]

.

Comment 10

[Dan Mosedale (:dmosedale, :dmose)]

Attachment: Bug 1731152 - Fix secondary spotlight button to look like a link in high-contrast mode, r?morgan

Comment 11

[Dan Mosedale (:dmosedale, :dmose)]

Attachment: Bug 1731152 - Fix spotlight dialog link in HCM mode, r?morgan!

Comment 12

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/cfd8f0c6aadb
Fix spotlight dialog link in HCM mode, r=morgan

Comment 13

[Atila Butkovits]

https://hg.mozilla.org/mozilla-central/rev/cfd8f0c6aadb

Comment 14

[Cristian Fogel [:cfogel]]

Confirmed issue with 94.0a1Build ID 20210916214506 on Win10.
Fix verified with 94.0b2.

Comment 15

[Mihai Boldan, Desktop QA [:mboldan]]

Based on Comment 14, I'm marking this issue as Verified Fixed.