1731160 - mach command support for comm-central

Status: RESOLVED FIXED

(Thunderbird :: Build Config, enhancement)

Description

[Rob Lemley [:rjl]]

There's situations where implementing Thunderbird specific mach commands would be an ideal fix. Currently it cannot be done without registering mach_commands.py files in mozilla-cenrtral. Bug 1731158 creates a path forward. This bug is for the comm-central work to make use of it.

Comment 1

[Rob Lemley [:rjl]]

Attachment: Bug 1731160 - mach initialization for Thunderbird mach commands. r=darktrojan

Creating mach commands in comm-central. The initialize function
first calls the mozilla-central mach initialize. The driver
instance that is returned is then modified.

This implementation allows for new command categories and new mach
command modules. Mach settings providers can also be added in the
mach_commands files.

A sample command is implemented in comm/python/mach/mach_commands.py

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/86650caf0044
mach initialization for Thunderbird mach commands. r=darktrojan

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/7c3baedab88f
Follow-up: Black linter reformatting. rs=linting

Comment 4

[Geoff Lankow (:darktrojan)]

I removed this (both patches) so that mach wasn't completely busted. I'm not sure whether this bug is the problem or bug 1731158, but this one is much easier to remove until a solution is found.

https://hg.mozilla.org/comm-central/rev/21a15680d2eef374e2a46dcfe9ef6ad895b36879

Comment 5

[Rob Lemley [:rjl]]

Updated D125984 with a fix for the build failure and rolled in the formatting follow-up as well.

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/3d09f7e2e0ff
mach initialization for Thunderbird mach commands. r=darktrojan