Closed Bug 1731160 Opened 4 months ago Closed 2 months ago

mach command support for comm-central

Categories

(Thunderbird :: Build Config, enhancement)

enhancement

Tracking

(thunderbird_esr91 wontfix, thunderbird95 wontfix)

RESOLVED FIXED
96 Branch
Tracking Status
thunderbird_esr91 --- wontfix
thunderbird95 --- wontfix

People

(Reporter: rjl, Assigned: rjl)

References

(Blocks 1 open bug)

Details

Attachments

(1 file)

There's situations where implementing Thunderbird specific mach commands would be an ideal fix. Currently it cannot be done without registering mach_commands.py files in mozilla-cenrtral. Bug 1731158 creates a path forward. This bug is for the comm-central work to make use of it.

Creating mach commands in comm-central. The initialize function
first calls the mozilla-central mach initialize. The driver
instance that is returned is then modified.

This implementation allows for new command categories and new mach
command modules. Mach settings providers can also be added in the
mach_commands files.

A sample command is implemented in comm/python/mach/mach_commands.py

Assignee: nobody → rob
Attachment #9241820 - Attachment description: WIP: Bug 1731160 - mach initialization for Thunderbird mach commands. → Bug 1731160 - mach initialization for Thunderbird mach commands. r=darktrojan
Status: NEW → ASSIGNED
Blocks: 1742711

Pushed by thunderbird@calypsoblue.org:
https://hg.mozilla.org/comm-central/rev/86650caf0044
mach initialization for Thunderbird mach commands. r=darktrojan

Status: ASSIGNED → RESOLVED
Closed: 2 months ago
Resolution: --- → FIXED
Pushed by thunderbird@calypsoblue.org:
https://hg.mozilla.org/comm-central/rev/7c3baedab88f
Follow-up: Black linter reformatting. rs=linting
Target Milestone: --- → 96 Branch

I removed this (both patches) so that mach wasn't completely busted. I'm not sure whether this bug is the problem or bug 1731158, but this one is much easier to remove until a solution is found.

https://hg.mozilla.org/comm-central/rev/21a15680d2eef374e2a46dcfe9ef6ad895b36879

Status: RESOLVED → REOPENED
Resolution: FIXED → ---

Updated D125984 with a fix for the build failure and rolled in the formatting follow-up as well.

Pushed by mkmelin@iki.fi:
https://hg.mozilla.org/comm-central/rev/3d09f7e2e0ff
mach initialization for Thunderbird mach commands. r=darktrojan

Status: REOPENED → RESOLVED
Closed: 2 months ago2 months ago
Resolution: --- → FIXED
Regressions: 1744122
You need to log in before you can comment on or make changes to this bug.