1731262 - Crash in [@ std::sys_common::backtrace::__rust_begin_short_backtrace<T>]

Status: RESOLVED FIXED

(Core :: Graphics: WebRender, defect)

Description

[Pascal Chevrel:pascalc (PTO until April 26)]

Crash report: https://crash-stats.mozilla.org/report/index/17cdd588-f4a1-4735-b627-810c90210917

Reason: EXCEPTION_ACCESS_VIOLATION_READ

Top 6 frames of crashing thread:

0 xul.dll std::sys_common::backtrace::__rust_begin_short_backtrace<closure-0, tuple<>> ../a178d0322ce20e33eac124758e837cbd80a6f633/library/std/src/sys_common/backtrace.rs:125
1 xul.dll core::ops::function::FnOnce::call_once<closure-0, tuple<>> ../a178d0322ce20e33eac124758e837cbd80a6f633/library/core/src/ops/function.rs:227
2 xul.dll std::sys::windows::thread::{{impl}}::new::thread_start ../a178d0322ce20e33eac124758e837cbd80a6f633//library/std/src/sys/windows/thread.rs:56
3 kernel32.dll BaseThreadInitThunk 
4 ntdll.dll RtlUserThreadStart 
5 kernelbase.dll TerminateProcessOnMemoryExhaustion 

This is a new crash that started manifesting in 93.0b6

Comment 1

[Pascal Chevrel:pascalc (PTO until April 26)]

All crashes are on Windows.
93.0b6 changelog: https://hg.mozilla.org/releases/mozilla-beta/pushloghtml?fromchange=FIREFOX_93_0b5_RELEASE&tochange=FIREFOX_93_0b6_RELEASE

Comment 2

[Jeff Muizelaar [:jrmuizel]]

This looks SWGL related

Comment 3

[Jeff Muizelaar [:jrmuizel]]

Here's the stack from the minidump (https://crash-stats.mozilla.org/report/index/f52d354b-a00a-4267-973d-e8bf70210917#tab-rawdump):

>    [Inline Frame] xul.dll!webrender::profiler::register_thread(str) Line 1235    Unknown    Symbols loaded.
     [Inline Frame] xul.dll!webrender::compositor::sw_compositor::{{impl}}::new::{{closure}}(webrender::compositor::sw_compositor::{{impl}}::new::closure-0) Line 482    Unknown    Symbols loaded.
     xul.dll!std::sys_common::backtrace::__rust_begin_short_backtrace<closure-0,tuple<>>(webrender::compositor::sw_compositor::{{impl}}::new::closure-0 f) Line 125    Unknown    Symbols loaded.
     [Inline Frame] xul.dll!std::thread::{{impl}}::spawn_unchecked::{{closure}}::{{closure}}(std::thread::{{impl}}::spawn_unchecked::{{closure}}::closure-0) Line 481    Unknown    Symbols loaded.
     [Inline Frame] xul.dll!std::panic::{{impl}}::call_once(std::panic::AssertUnwindSafe<closure-0>) Line 347    Unknown    Symbols loaded.
     [Inline Frame] xul.dll!std::panicking::try::do_call(unsigned char * data) Line 401    Unknown    Symbols loaded.
     [Inline Frame] xul.dll!std::panicking::try(std::panic::AssertUnwindSafe<closure-0>) Line 365    Unknown    Symbols loaded.
     [Inline Frame] xul.dll!std::panic::catch_unwind(std::panic::AssertUnwindSafe<closure-0>) Line 434    Unknown    Symbols loaded.
     [Inline Frame] xul.dll!std::thread::{{impl}}::spawn_unchecked::{{closure}}(std::thread::{{impl}}::spawn_unchecked::closure-0) Line 480    Unknown    Symbols loaded.
     xul.dll!core::ops::function::FnOnce::call_once<closure-0,tuple<>>(std::thread::{{impl}}::spawn_unchecked::closure-0 *) Line 227    Unknown    Symbols loaded.
     [Inline Frame] xul.dll!alloc::boxed::{{impl}}::call_once() Line 1575    Unknown    Symbols loaded.
     [Inline Frame] xul.dll!alloc::boxed::{{impl}}::call_once() Line 1575    Unknown    Symbols loaded.
     xul.dll!std::sys::windows::thread::{{impl}}::new::thread_start() Line 56    Unknown    Symbols loaded.

Comment 4

[Jeff Muizelaar [:jrmuizel]]

It looks like webrender::profiler::PROFILER_HOOKS is partially initialized or something.

Comment 5

[Jeff Muizelaar [:jrmuizel]]

Attachment: Bug 1731262. Install profiler hooks earlier.

There could be a race between installing the profiler hooks
and the SwCompositor threads starting up. If we install them
earlier that should help.

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/4777e9e4da67
Install profiler hooks earlier. r=aosmond

Comment 7

[Jeff Muizelaar [:jrmuizel]]

Comment on attachment 9241838 [details]
Bug 1731262. Install profiler hooks earlier.

Beta/Release Uplift Approval Request

• User impact if declined: startup crashes
• Is this code covered by automated tests?: No
• Has the fix been verified in Nightly?: No
• Needs manual test from QE?: No
• If yes, steps to reproduce:
• List of other uplifts needed: None
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): Just moves the order of installing the profiler_hooks. Should be very low risk. In the worst case this will have no impact on this crash.
• String changes made/needed:

Comment 8

[Marian-Vasile Laza]

https://hg.mozilla.org/mozilla-central/rev/4777e9e4da67

Comment 9

[Pascal Chevrel:pascalc (PTO until April 26)]

Comment on attachment 9241838 [details]
Bug 1731262. Install profiler hooks earlier.

This is a new top crash on 93 beta, approved for beta 7, thanks.

Comment 10

[Pascal Chevrel:pascalc (PTO until April 26)]

https://hg.mozilla.org/releases/mozilla-beta/rev/d18009b6f24c

Comment 11

[Pascal Chevrel:pascalc (PTO until April 26)]

Beta 7 is not crashing