[wpt-sync] Sync PR 30801 - Don't look for a sibling of a resumed node if we've seen all children.
Categories
(Core :: Layout, task, P4)
Tracking
()
| Tracking | Status | |
|---|---|---|
| firefox95 | --- | fixed |
People
(Reporter: mozilla.org, Unassigned)
References
()
Details
(Whiteboard: [wptsync downstream])
Sync web-platform-tests PR 30801 into mozilla-central (this bug is closed when the sync is complete).
PR: https://github.com/web-platform-tests/wpt/pull/30801
Details from upstream follow.
b'Morten Stenshorne <mstensho@chromium.org>' wrote:
Don't look for a sibling of a resumed node if we've seen all children.
NGBlockChildIterator would call NGBlockNode::NextSibling() in an inline
formatting context when we were at the last child break token for a
float. Floats become regular block children when resumed, so we cannot
really call NextSibling() on them at all. And we don't have to, since
there'll either be a break token to tell us where to resume in the
inline formatting context, if there is anything at all to resume.
Otherwise HasSeenAllChildren() will return true, and we can stop.Fix and clean up NGBlockChildIterator, to hopefully make it easier to
follow.Bug: 1249828
Change-Id: I91d03a2bfd0394a594d99ba512a992f29b4848ba
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3162059
Reviewed-by: Ian Kilpatrick \<ikilpatrick@chromium.org>
Commit-Queue: Morten Stenshorne \<mstensho@chromium.org>
Cr-Commit-Position: refs/heads/main@{#921777}
|
Assignee | |
Updated•3 years ago
|
|
|
Assignee | |
Comment 1•3 years ago
|
||
Pushed to try (stability) https://treeherder.mozilla.org/#/jobs?repo=try&revision=3fbb3031ff5513e9b3bc0c98e0f368edf74f8799
|
|
Assignee | |
Comment 2•3 years ago
|
||
CI Results
Ran 11 Firefox configurations based on mozilla-central, and Firefox, Chrome, and Safari on GitHub CI
Total 1 tests
Status Summary
Firefox
PASS: 1
Chrome
PASS: 1
Safari
PASS: 1
Links
Pushed by wptsync@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/77d4baa9a677 [wpt PR 30801] - Don't look for a sibling of a resumed node if we've seen all children., a=testonly
Pushed by wptsync@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/53728bfa49bc [wpt PR 30801] - Don't look for a sibling of a resumed node if we've seen all children., a=testonly
|
||
Comment 5•3 years ago
|
||
| bugherder | ||
Description
•