Closed Bug 1731297 Opened 3 years ago Closed 3 years ago

[wpt-sync] Sync PR 30707 - [@layer] User layer order to resolve @font-face family name conflicts

Categories

(Core :: CSS Parsing and Computation, task, P4)

Product:
Core
Component:
CSS Parsing and Computation
Type:
task

Tracking

()

Status:
RESOLVED FIXED
Milestone:
95 Branch
Tracking Flags:
Tracking Status
firefox95 --- fixed

People

(Reporter: mozilla.org, Unassigned)

References

(
URL
)

Details

(Whiteboard: [wptsync downstream])

Sync web-platform-tests PR 30707 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/30707
Details from upstream follow.

b'Xiaocheng Hu <xiaochengh@chromium.org>' wrote:

[@layer] User layer order to resolve @font-face family name conflicts

@font-face rules and other name-defining at rules are different that,
rules with the same font-family name do not completely override each
other, but have different priorities in font fallback.

Therefore, this patch modifies CSSSegmentedFontFace to store CSS-
connected font faces in the cascade layer order, so that font faces in
a higher layer will be attempted first in font fallback.

Bug: 1096765
Change-Id: Iccd84b0fd48f1e13eb536a48eabc7f22ccd32149
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3159011
Commit-Queue: Xiaocheng Hu \<xiaochengh@chromium.org>
Reviewed-by: Anders Hartvoll Ruud \<andruud@chromium.org>
Cr-Commit-Position: refs/heads/main@{#921814}

Component: web-platform-tests → CSS Parsing and Computation
Product: Testing → Core

CI Results

Ran 11 Firefox configurations based on mozilla-central, and Firefox, Chrome, and Safari on GitHub CI

Total 1 tests and 4 subtests

Status Summary

Firefox

OK : 1
PASS: 1
FAIL: 3

Chrome

OK : 1
FAIL: 4

Safari

OK : 1
FAIL: 4

Links

Gecko CI (Treeherder)
GitHub PR Head
GitHub PR Base

Details

New Tests That Don't Pass

/css/css-cascade/layer-font-face-override.html
@font-face layered overrides unlayered: FAIL (Chrome: FAIL, Safari: FAIL)
@font-face override between layers: FAIL (Chrome: FAIL, Safari: FAIL)
@font-face override update with appended sheet 1: FAIL (Chrome: FAIL, Safari: FAIL)

Pushed by wptsync@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/0366db38d196
[wpt PR 30707] - [@layer] User layer order to resolve @font-face family name conflicts, a=testonly
https://hg.mozilla.org/integration/autoland/rev/aa2632dfd76a
[wpt PR 30707] - Update wpt metadata, a=testonly
Pushed by wptsync@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/c900f5782a79
[wpt PR 30707] - [@layer] User layer order to resolve @font-face family name conflicts, a=testonly
https://hg.mozilla.org/integration/autoland/rev/4a50f9eb85aa
[wpt PR 30707] - Update wpt metadata, a=testonly

https://hg.mozilla.org/mozilla-central/rev/c900f5782a79
https://hg.mozilla.org/mozilla-central/rev/4a50f9eb85aa

Status: NEW → RESOLVED
Closed: 3 years ago
status-firefox95: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 95 Branch
You need to log in before you can comment on or make changes to this bug.