1731305 - [wpt-sync] Sync PR 30811 - [Re-Factor Client Hints] (5) Remove (unlaunched) `lang` client hint {FOLLOWUP}

Status: RESOLVED FIXED

(Testing :: web-platform-tests, task, P4)

Description

[Web Platform Test Sync Bot (Matrix: #interop:mozilla.org)]

Sync web-platform-tests PR 30811 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/30811
Details from upstream follow.

b'Ari Chivukula <[e-mail]>' wrote:

[Re-Factor Client Hints] (5) Remove (unlaunched) lang client hint {FOLLOWUP}

https://chromium-review.googlesource.com/c/chromium/src/+/3160286
introduced upstream flakiness because several uses of
lang were not removed. This fixes that issue.

Change-Id: Ie9fd542667f1636b51ebb5078ff651f2b63a1ee2
bug: 1250096
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3163688
Reviewed-by: Yoav Weiss \<[e-mail]>
Commit-Queue: Yoav Weiss \<[e-mail]>
Auto-Submit: Ari Chivukula \<[e-mail]>
Cr-Commit-Position: refs/heads/main@{#922014}

Comment 1

[Web Platform Test Sync Bot (Matrix: #interop:mozilla.org)]

Pushed to try (stability) https://treeherder.mozilla.org/#/jobs?repo=try&revision=edd6e144a0fee72b60324be5ce9fe57e337c0178

Comment 2

[Web Platform Test Sync Bot (Matrix: #interop:mozilla.org)]

CI Results

Ran 11 Firefox configurations based on mozilla-central, and Firefox, Chrome, and Safari on GitHub CI

Total 3 tests and 1 subtests

Status Summary

Firefox

OK : 3
PASS: 1
FAIL: 6

Chrome

OK : 3
PASS: 7

Safari

OK : 3
PASS: 1
FAIL: 6

Links

Gecko CI (Treeherder)
GitHub PR Head
GitHub PR Base

Details

New Tests That Don't Pass

/client-hints/accept-ch-feature-policy.sub.https.html
Accept-CH header test: FAIL (Chrome: PASS, Safari: FAIL)
Cross-Origin Accept-CH header test: FAIL (Chrome: PASS, Safari: FAIL)
/client-hints/accept-ch-no-feature-policy-navigation.https.html
Client hints not loaded on cross-origin iframe request with no feature policy.: FAIL (Chrome: PASS, Safari: FAIL)
Client hints loaded on same-origin iframe request with no feature policy.: FAIL (Chrome: PASS, Safari: FAIL)
Client hints loaded on cross-origin iframe request with allow list.: FAIL (Chrome: PASS, Safari: FAIL)
Client hints loaded on same-origin iframe request with allow list.: FAIL (Chrome: PASS, Safari: FAIL)

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/2e44010f3ead
[wpt PR 30811] - [Re-Factor Client Hints] (5) Remove (unlaunched) `lang` client hint {FOLLOWUP}, a=testonly

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/ede344d6f24d
[wpt PR 30811] - [Re-Factor Client Hints] (5) Remove (unlaunched) `lang` client hint {FOLLOWUP}, a=testonly

Comment 5

[Cristian Tuns]

https://hg.mozilla.org/mozilla-central/rev/ede344d6f24d