Closed Bug 1731352 Opened 3 years ago Closed 3 years ago

Frequent <random_test>/s | A promise chain failed to handle a rejection: this.commands is null - stack: get target@resource://devtools/client/framework/toolbox.js:535:5 when Gecko 94 merges to Beta on 2021-10-04

Categories

(DevTools :: Framework, defect)

Product:
DevTools
Component:
Framework
Type:
defect

Tracking

(firefox-esr78 unaffected, firefox-esr91 unaffected, firefox92 unaffected, firefox93 unaffected, firefox94+ verified)

Status:
VERIFIED FIXED
Milestone:
94 Branch
Tracking Flags:
Tracking Status
firefox-esr78 --- unaffected
firefox-esr91 --- unaffected
firefox92 --- unaffected
firefox93 --- unaffected
firefox94 + verified

People

(Reporter: aryx, Assigned: ochameau)

References

Details

(Keywords: regression)

Attachments

(1 file, 1 obsolete file)

Bug 1731352 - [devtools] Prevent exception from Toolbox code when closing the toolbox.
48 bytes, text/x-phabricator-request
Details | Review

At least 4 failures in today's central-as-early/late-beta simulations. Regression from bug 1729925?

[task 2021-09-17T16:24:30.659Z] 16:24:30     INFO - Tab removed and finished closing
[task 2021-09-17T16:24:30.660Z] 16:24:30     INFO - TEST-PASS | devtools/client/debugger/test/mochitest/browser_dbg-settings-disable-javascript.js | The main process DevToolsServer has no pending connection when the test ends - 
[task 2021-09-17T16:24:30.661Z] 16:24:30     INFO - Console message: [JavaScript Error: "TypeError: this.commands is null" {file: "resource://devtools/client/framework/toolbox.js" line: 535}]
[task 2021-09-17T16:24:30.662Z] 16:24:30     INFO - Buffered messages finished
[task 2021-09-17T16:24:30.667Z] 16:24:30     INFO - TEST-UNEXPECTED-FAIL | devtools/client/debugger/test/mochitest/browser_dbg-settings-disable-javascript.js | A promise chain failed to handle a rejection: this.commands is null - stack: get target@resource://devtools/client/framework/toolbox.js:535:5
[task 2021-09-17T16:24:30.668Z] 16:24:30     INFO - initPerformance@resource://devtools/client/framework/toolbox.js:3947:27
[task 2021-09-17T16:24:30.668Z] 16:24:30     INFO - _onTargetAvailable@resource://devtools/client/framework/toolbox.js:716:18
[task 2021-09-17T16:24:30.668Z] 16:24:30     INFO - Async*_emit@resource://devtools/shared/event-emitter.js:244:34
[task 2021-09-17T16:24:30.668Z] 16:24:30     INFO - emitAsync@resource://devtools/shared/event-emitter.js:194:25
[task 2021-09-17T16:24:30.668Z] 16:24:30     INFO - emitAsync@resource://devtools/shared/event-emitter.js:346:25
[task 2021-09-17T16:24:30.668Z] 16:24:30     INFO - _onTargetAvailable@resource://devtools/shared/commands/target/target-command.js:203:33
[task 2021-09-17T16:24:30.668Z] 16:24:30     INFO - Async*_emit@resource://devtools/shared/event-emitter.js:244:34
[task 2021-09-17T16:24:30.669Z] 16:24:30     INFO - emit@resource://devtools/shared/event-emitter.js:190:18
[task 2021-09-17T16:24:30.669Z] 16:24:30     INFO - emit@resource://devtools/shared/event-emitter.js:342:18
[task 2021-09-17T16:24:30.669Z] 16:24:30     INFO - _onTargetAvailable@resource://devtools/client/fronts/watcher.js:60:10
[task 2021-09-17T16:24:30.669Z] 16:24:30     INFO - _emit@resource://devtools/shared/event-emitter.js:244:34
[task 2021-09-17T16:24:30.670Z] 16:24:30     INFO - emit@resource://devtools/shared/event-emitter.js:190:18
[task 2021-09-17T16:24:30.670Z] 16:24:30     INFO - emit@resource://devtools/shared/event-emitter.js:342:18
[task 2021-09-17T16:24:30.670Z] 16:24:30     INFO - onPacket@resource://devtools/shared/protocol/Front.js:336:13
[task 2021-09-17T16:24:30.670Z] 16:24:30     INFO - onPacket@resource://devtools/client/devtools-client.js:482:13
[task 2021-09-17T16:24:30.671Z] 16:24:30     INFO - send/<@resource://devtools/shared/transport/local-transport.js:68:25
[task 2021-09-17T16:24:30.671Z] 16:24:30     INFO - exports.makeInfallible/<@resource://devtools/shared/ThreadSafeDevToolsUtils.js:103:22
[task 2021-09-17T16:24:30.671Z] 16:24:30     INFO - DevToolsUtils.executeSoon*exports.executeSoon@resource://devtools/shared/DevToolsUtils.js:54:21
[task 2021-09-17T16:24:30.671Z] 16:24:30     INFO - send@resource://devtools/shared/transport/local-transport.js:56:21
[task 2021-09-17T16:24:30.671Z] 16:24:30     INFO - send@resource://devtools/server/devtools-server-connection.js:99:20
[task 2021-09-17T16:24:30.671Z] 16:24:30     INFO - _sendEvent@resource://devtools/shared/protocol/Actor.js:72:15
[task 2021-09-17T16:24:30.671Z] 16:24:30     INFO - initialize/<@resource://devtools/shared/protocol/Actor.js:46:16
[task 2021-09-17T16:24:30.671Z] 16:24:30     INFO - _emit@resource://devtools/shared/event-emitter.js:244:34
[task 2021-09-17T16:24:30.671Z] 16:24:30     INFO - emit@resource://devtools/shared/event-emitter.js:190:18
[task 2021-09-17T16:24:30.671Z] 16:24:30     INFO - emit@resource://devtools/shared/event-emitter.js:342:18
[task 2021-09-17T16:24:30.671Z] 16:24:30     INFO - notifyTargetAvailable@resource://devtools/server/actors/watcher.js:224:10
[task 2021-09-17T16:24:30.672Z] 16:24:30     INFO - connectFromContent@resource://devtools/server/connectors/js-window-actor/DevToolsFrameParent.jsm:143:13
[task 2021-09-17T16:24:30.672Z] 16:24:30     INFO - receiveMessage@resource://devtools/server/connectors/js-window-actor/DevToolsFrameParent.jsm:209:21
[task 2021-09-17T16:24:30.672Z] 16:24:30     INFO - JSActor query*_createTargetActor@resource://devtools/server/connectors/js-window-actor/DevToolsFrameChild.jsm:325:10
[task 2021-09-17T16:24:30.672Z] 16:24:30     INFO - instantiate@resource://devtools/server/connectors/js-window-actor/DevToolsFrameChild.jsm:227:14
[task 2021-09-17T16:24:30.672Z] 16:24:30     INFO - handleEvent@resource://devtools/server/connectors/js-window-actor/DevToolsFrameChild.jsm:609:12
[task 2021-09-17T16:24:30.672Z] 16:24:30     INFO - Rejection date: Fri Sep 17 2021 16:24:30 GMT+0000 (Coordinated Universal Time) - false == true - JS frame :: resource://testing-common/PromiseTestUtils.jsm :: assertNoUncaughtRejections :: line 285
[task 2021-09-17T16:24:30.672Z] 16:24:30     INFO - Stack trace:
[task 2021-09-17T16:24:30.672Z] 16:24:30     INFO - resource://testing-common/PromiseTestUtils.jsm:assertNoUncaughtRejections:285
[task 2021-09-17T16:24:30.672Z] 16:24:30     INFO - chrome://mochikit/content/browser-test.js:nextTest:625
[task 2021-09-17T16:24:30.672Z] 16:24:30     INFO - chrome://mochikit/content/browser-test.js:testScope/test_finish/<:1555
[task 2021-09-17T16:24:30.672Z] 16:24:30     INFO - chrome://mochikit/content/browser-test.js:run:1470
Flags: needinfo?(poirot.alex)
Flags: needinfo?(poirot.alex)
See Also: → 1728815

This is similar to bug 1728815, but now the toolbox itself is being destroyed and clears commands.
But we can also check if the related target is destroyed.

Assignee: nobody → poirot.alex
Status: NEW → ASSIGNED
Pushed by apoirot@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/5f34eb5761c4
[devtools] Prevent exception from Toolbox code when closing the toolbox. r=jdescottes

Comment on attachment 9242196 [details]
Bug 1731352 - [devtools] Use shared reload helpers in debugger mochitests

Revision D126179 was moved to bug 1731728. Setting attachment 9242196 [details] to obsolete.

Attachment #9242196 - Attachment is obsolete: true

https://hg.mozilla.org/mozilla-central/rev/5f34eb5761c4

Status: ASSIGNED → RESOLVED
Closed: 3 years ago
status-firefox94: affected → fixed
Resolution: --- → FIXED
Target Milestone: --- → 94 Branch
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: