Migrate commonDialog.dtd to Fluent
Categories
(Toolkit :: General, task)
Tracking
()
Tracking | Status | |
---|---|---|
firefox105 | --- | fixed |
People
(Reporter: zbraniecki, Assigned: eemeli)
References
(Blocks 1 open bug)
Details
Attachments
(2 files)
It is used in one XHTML file, and in one JSM file where XHTML is built dynamically - https://searchfox.org/mozilla-central/search?q=commonDialog.dtd&path=&case=false®exp=false
Assignee | ||
Comment 1•2 years ago
|
||
This migrates only the strings used by commonDialog.xhtml
Updated•2 years ago
|
Assignee | ||
Comment 2•2 years ago
|
||
This migrates the remaining strings from both commonDialog.dtd and
dialogOverlay.dtd into a single new tabprompts.ftl file, as they are
only used by TabModalPrompt.
Depends on D154422
Assignee | ||
Comment 3•2 years ago
|
||
The strings in dialogOverlay.dtd
got migrated here as well, as they and a part of the commonDialog.dtd
strings are used by TabModalPrompt
.
Updated•2 years ago
|
Updated•2 years ago
|
Pushed by earo@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/123d9498cd15 Migrate commonDialog strings from DTD to FTL. r=fluent-reviewers,mossop,flod https://hg.mozilla.org/integration/autoland/rev/50a6a70d01fd Migrate TabModalPrompt strings from DTD to FTL. r=fluent-reviewers,mossop,flod
Comment 5•2 years ago
•
|
||
Backed out 2 changesets (Bug 1731353) for causing mochitest failures on test_ui_modalprompt.html and multiple bc failures.
Backout link
Push with failures <--> ay11
Failure Log
Also bc1 failure log
Also bc11 failure log
Also bc30 failure log
Pushed by earo@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/16867734122d Migrate commonDialog strings from DTD to FTL. r=fluent-reviewers,mossop,flod https://hg.mozilla.org/integration/autoland/rev/ed3a9b7afa88 Migrate TabModalPrompt strings from DTD to FTL. r=fluent-reviewers,mossop,flod
Assignee | ||
Comment 7•2 years ago
|
||
There was a silly bug left in the patch, and I had not ran all the test suites targeting this. Fixed now, and re-ran the failed jobs on treeherder: https://treeherder.mozilla.org/jobs?repo=try&revision=1e67e549a76ffbd5bd214383c76d30d4f495b9c2
Comment 8•2 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/16867734122d
https://hg.mozilla.org/mozilla-central/rev/ed3a9b7afa88
Description
•