1731366 - regression: column selector (mouse rightclick on table header) in cookie inspector not highlighting visible columns anymore

Status: NEW

(DevTools :: Storage Inspector, defect, P3)

Description

[ddpm]

Attachment: ff92_storageinspector.png

User Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.13; rv:92.0) Gecko/20100101 Firefox/92.0

Steps to reproduce:

Try to choose the columns in the cookie inspector of Firefox devtools.

Actual results:

In older versions than current Firefox 92.0 on a (old) macbook with 10.13 High Sierra the column selector highlighted the visible columns of the cookie inspector tables.

This is not anymore the case as shown in Screenshot.

I do not know when the last version of Firefox was that had not this problem, but it worked in older Firefox versions.

Expected results:

The chosen columns should be highlighted in the column chooser. Either by icon (as shown on currently on https://developer.mozilla.org/en-US/docs/Tools/Storage_Inspector

or by a bold font.

Comment 1

[BugBot [:suhaib / :marco/ :calixte]]

The Bugbug bot thinks this bug should belong to the 'DevTools::Inspector' component, and is moving the bug to that component. Please revert this change in case you think the bot is wrong.

Comment 2

[Julian Descottes [:jdescottes]]

Hi, this seems similar to Bug 1717446. Can you go to about:config and check the value of widget.macos.native-context-menus ?

Comment 3

[ddpm]

The value widget.macos.native-context-menus was set to true (default).
I changed to false, no difference.
I closed Firefox and restarted it, no difference.

The checkmarks are still missing.

I do not know if that helps, but since around 2 years (+-1 year I do not remember version when appeared first) sometimes the repainting is not immediately happening when editing in a form or graphic artifacts are shown and I assume this relates to graphic card / opengl issues? I solve that then by moving or resizing the browser window a bit.
MacBook Pro (13 Zoll, Anfang/early 2011)
2,3 GHz Intel Core i5
Intel HD Graphics 3000 512 MB

Comment 4

[Julian Descottes [:jdescottes]]

Thanks for the info, can you also go to about:support and copy the data to this bug? This might be related to either a specific hardware or a specific setting and about:support should surface anything interesting.

Comment 5

[ddpm]

Attachment: about:support

Comment 6

[Julian Descottes [:jdescottes]]

Thanks.

Even if this happens both with and without native-context-menus for you, that's still the only way I can reproduce the issue consistently, so let's investigate that.

Markus, you worked on native-context-menus and you might know more about this. When I disable native-context-menus, the "checkmarks" are no longer displayed in the Storage Inspector table header context menu. For the reporter, they are are never displayed, regardless of the native-context-menu pref, but that's on an older macos: 10.13. We started having issues with checkmarks in menus 3-4 months ago (Bug 1716567, Bug 1717446), so I wonder if this could be a regression related to native context menu work? Will ask for a regression window in the other bugs.

Comment 7

[Julian Descottes [:jdescottes]]

From the regression window in Bug 1716567, this could be related to Bug 1690842, and overall the removal of native theme for content. This might be because the DevTools toolbox is loaded in a browser element with type="content"?

Comment 8

[ddpm]

Problem still exists in Firefox 94.0.

Comment 9

[Markus Stange [:mstange]]

Sorry for taking so long to get to this.

With widget.macos.native-context-menus set to false, I can reproduce this in the Storage panel, but not in the Network panel. I also suspect that this was broken by the non-native theme. Emilio, can you take a look?

Comment 10

[Markus Stange [:mstange]]

Oh, yes, bug 1716567 looks like exactly the same issue.

What I haven't understood yet is why ddpm isn't getting native context menus on 10.13. But that's somewhat orthogonal to the lack of checkmarks.

Comment 11

[ddpm]

Problem still exists in Firefox 96.0.2 on Macos 10.13.6 High Sierra.

Network panel shows checkmarks, Storage panel not, regardless of widget.macos.native-context-menus set to false/true

On modern M1 Macbook Air (12.1 Montery) all fine.
The old Macbook still in daily webdev use due vagrant providers not supporting M1 CPUs yet..

Comment 12

[Emilio Cobos Álvarez (:emilio)]

Yeah, so it's definitely related to the non-native theme.

On the storage panel we use the storagePopupSet, which is in the devtools toolbox and thus uses the non-native theme. The network panel uses the menu-api panels which inject the popup in the top level browser.xhtml (and thus use the native theme).

Comment 13

[Emilio Cobos Álvarez (:emilio)]

Julian, we could add support for these to the non-native theme, but it's a bit messy because the platform styling of each is different. Do you know how hard would it be to move the storagePopupSet to use the menu API like the network panel does?

Comment 14

[Julian Descottes [:jdescottes]]

Hi Emilio!

Keeping the needinfo to take a look, but that should be doable.
Looks like the alternative is too complex to implement so let's forget about this, we'll handle it in DevTools.

Comment 15

[ddpm]

Hello, I want to report that FF97.0 on macos high sierra 10.13.6 now shows the checkmarks in cookie inspector. :-)

Thank you.

Comment 16

[ddpm]

Attachment: bug1731336_ff97.0_ok.png ok in Firefox 97.0

Comment 17

[Julian Descottes [:jdescottes]]

Thanks for the update!

Comment 18

[Julien Wajsberg [:julienw]]

This is actually still affecting me on Linux! (checked on a recent Nightly 20220830092750).

I'm also copying over the regressing bug information from bug 1716567.

Comment 20

[BugBot [:suhaib / :marco/ :calixte]]

Set release status flags based on info from the regressing bug 1690842

Comment 21

[BugBot [:suhaib / :marco/ :calixte]]

Set release status flags based on info from the regressing bug 1690842