Closed Bug 1731523 Opened 3 years ago Closed 2 years ago

Remove Nimbus client code from completed "Firefox/100.0" UA string experiment

Categories

(Core :: Networking: HTTP, task, P3)

task

Tracking

()

RESOLVED FIXED
100 Branch
Tracking Status
firefox-esr78 --- unaffected
firefox-esr91 --- unaffected
firefox92 --- wontfix
firefox93 --- wontfix
firefox94 --- wontfix
firefox95 --- wontfix
firefox96 --- wontfix
firefox97 --- wontfix
firefox98 --- wontfix
firefox99 --- wontfix
firefox100 --- fixed

People

(Reporter: cpeterson, Assigned: cpeterson)

References

Details

Attachments

(2 files, 1 obsolete file)

Summary: Removed Nimbus client code from completed "Firefox/100.0" UA string experiment → Remove Nimbus client code from completed "Firefox/100.0" UA string experiment

Here is a try push of the browser-chrome tests for the UA string:

https://treeherder.mozilla.org/jobs?repo=try&revision=b040f50045ea54e48b848703cf9faf565b7e0063

The test failures are unrelated to the UA string code or tests.

This code was added in bug 1719070 to run an experiment to see if sending a "Firefox 100" UA string causes any major webcompat problems. The experiment ended on 2021-09-28, so we no longer need this code.

This changeset is effectively a backout of bug 1719070's https://hg.mozilla.org/mozilla-central/rev/56e4a835369f.

This experiment ended on 2021-09-28, so we no longer need this code.

Depends on D126408

(In reply to Chris Peterson [:cpeterson] from comment #3)

This experiment ended on 2021-09-28, so we no longer need this code.

That is 6 days in the future.

(In reply to Worcester12345 from comment #4)

(In reply to Chris Peterson [:cpeterson] from comment #3)

This experiment ended on 2021-09-28, so we no longer need this code.

That is 6 days in the future.

Good eye! I don't plan to land this patch until after the experiment ends. As such, I'd like this commit message to reflect that the experiment has already ended. :)

The Firefox 100 experiment was broken (due to client bug 1732875 because I misunderstood how Nimbus experiment enrollment worked). Thanks to :denschub for finding and fixing that bug!

I will need to rerun the Firefox 100 experiment in Nightly 95, so this bug's patches to remove the Firefox experiment code can't land until Nightly 96.

There are some r+ patches which didn't land and no activity in this bug for 2 weeks.
:cpeterson, could you have a look please?
For more information, please visit auto_nag documentation.

Flags: needinfo?(cpeterson)
Flags: needinfo?(andrei.br92)

(In reply to Release mgmt bot [:sylvestre / :calixte / :marco for bugbug] from comment #7)

There are some r+ patches which didn't land and no activity in this bug for 2 weeks.
:cpeterson, could you have a look please?

I need to rerun the related Nightly experiment before I can land these patches to remove the experiment's code.

In the meantime, I will set status-firefox95=wontfix.

Flags: needinfo?(cpeterson)
Flags: needinfo?(andrei.br92)
Blocks: 1748798, 1732875
No longer depends on: 1732875
Status: NEW → ASSIGNED
Attachment #9242563 - Attachment is obsolete: true

This "Firefox 100 User-Agent String" setting was added in bug 1748798 to help test if sending a "Firefox 100" UA string causes any major webcompat problems.

The "general.useragent.forceVersion100" pref will be removed in the next changeset.

Attachment #9242562 - Attachment description: Bug 1731523 - Remove "Firefox 100" experiment's client code. r?#necko-reviewers → Bug 1731523 - Part 2: Remove "Firefox 100" Nimbus experiment code. r?#necko-reviewers!

I landed approved patch #1 to remove the setting UI, so users won't be confused by the presence of a "Firefox 100 experiment" option in their Firefox 100. I'll land patch #2 after it's reviewed.

Pushed by cpeterson@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/1956d9694f34
Part 1: Remove "Firefox 100 User-Agent String" setting UI. r=fluent-reviewers,preferences-reviewers,Gijs
Keywords: leave-open
Pushed by cpeterson@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/3b28b05f9a09
Part 2: Remove "Firefox 100" Nimbus experiment code. r=necko-reviewers,kershaw
Status: ASSIGNED → RESOLVED
Closed: 2 years ago
Resolution: --- → FIXED
Target Milestone: --- → 100 Branch
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: