1731526 - Fix non-unified build errors in accessible/

Status: RESOLVED FIXED

(Core :: Disability Access APIs, defect, P3)

Description

[Chris Peterson [:cpeterson]]

Building with ac_add_options --disable-unified-build on macOS hits the following -Wunreachable-code-return warnings-as-errors:

accessible/base/TreeWalker.cpp:151:10: error: 'return' will never be executed [-Werror,-Wunreachable-code-return]
accessible/xpcom/xpcAccessibleMacInterface.mm:177:10: error: 'return' will never be executed [-Werror,-Wunreachable-code-return]

Comment 1

[Chris Peterson [:cpeterson]]

Attachment: Bug 1731526 - Fix non-unified build errors in accessible/. r?eeejay

accessible/base/TreeWalker.cpp:151:10: error: 'return' will never be executed [-Werror,-Wunreachable-code-return]
accessible/xpcom/xpcAccessibleMacInterface.mm:177:10: error: 'return' will never be executed [-Werror,-Wunreachable-code-return]

Comment 2

[Morgan Reschenberg [:morgan]]

Changing severity to P3/S4 for triage

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/998408ac9046
Fix non-unified build errors in accessible/. r=eeejay

Comment 4

[Cristian Tuns]

https://hg.mozilla.org/mozilla-central/rev/998408ac9046