Closed Bug 1731553 Opened 1 year ago Closed 1 year ago

Add support for "stackTrace" to ConsoleLogEntry and JavascriptLogEntry

Categories

(Remote Protocol :: WebDriver BiDi, task, P2)

Product:
Remote Protocol
Component:
WebDriver BiDi
Type:
task
Points:
2

Tracking

(firefox97 fixed)

Status:
RESOLVED FIXED
Milestone:
97 Branch
Tracking Flags:
Tracking Status
firefox97 --- fixed

People

(Reporter: whimboo, Assigned: whimboo)

References

(Depends on 1 open bug, Blocks 2 open bugs)

Details

(Whiteboard: [bidi-m2-mvp], [wptsync upstream])

Attachments

(3 files)

Bug 1731553 - [remote] Add shared module to handle stack frames.
48 bytes, text/x-phabricator-request
Details | Review
Bug 1731553 - [webdriver-bidi] Add support for "stackTrace" to "log.entryAdded".
48 bytes, text/x-phabricator-request
Details | Review
Bug 1731553 - [wdspec] Added tests to support stackTrace entries for log.entryAdded.
48 bytes, text/x-phabricator-request
Details | Review

Once support for ConcoleLogEntry and JavascriptLogEntry has been added we have to also support attaching the stacktrace for trace level ConsoleLogEntry entries, and JavascriptLogEntry.

Depends on: 1731548
Summary: Add support for sta for ConsoleLogEntry for log.entryAdded event → Add support for stackTrace to ConsoleLogEntry and JavascriptLogEntry
Summary: Add support for stackTrace to ConsoleLogEntry and JavascriptLogEntry → Add "stack" support to ConsoleLogEntry and JavascriptLogEntry
Summary: Add "stack" support to ConsoleLogEntry and JavascriptLogEntry → Add support for "stackTrace" to ConsoleLogEntry and JavascriptLogEntry

Note that via https://github.com/w3c/webdriver-bidi/pull/135 we might not want to add the stackTrace for every ConsoleLogEntry type.

Points: --- → 2
Priority: -- → P2
No longer depends on: 1731543
Assignee: nobody → hskupin
Status: NEW → ASSIGNED

(In reply to Henrik Skupin (:whimboo) [⌚️UTC+1] from comment #1)

Note that via https://github.com/w3c/webdriver-bidi/pull/135 we might not want to add the stackTrace for every ConsoleLogEntry type.

Based on the merged changes the stacktrace needs to be included for console API calls for the following methods: assert, error, warn and trace.

Depends on: 1744705
Attachment #9254118 - Attachment description: WIP: Bug 1731553 - [remote] Add shared module to handle stack frames. → Bug 1731553 - [remote] Add shared module to handle stack frames.
Attachment #9254119 - Attachment description: WIP: Bug 1731553 - [webdriver-bidi] Add support for "stackTrace" to "log.entryAdded". → Bug 1731553 - [webdriver-bidi] Add support for "stackTrace" to "log.entryAdded".
Pushed by hskupin@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/4ffae25ab5a9
[remote] Add shared module to handle stack frames. r=webdriver-reviewers,jdescottes
https://hg.mozilla.org/integration/autoland/rev/fd8c95f5ea3a
[webdriver-bidi] Add support for "stackTrace" to "log.entryAdded". r=webdriver-reviewers,jdescottes
https://hg.mozilla.org/integration/autoland/rev/598f068edcbc
[wdspec] Added tests to support stackTrace entries for log.entryAdded. r=webdriver-reviewers,jdescottes
Created web-platform-tests PR https://github.com/web-platform-tests/wpt/pull/31985 for changes under testing/web-platform/tests
Whiteboard: [bidi-m2-mvp] → [bidi-m2-mvp], [wptsync upstream]

https://hg.mozilla.org/mozilla-central/rev/4ffae25ab5a9
https://hg.mozilla.org/mozilla-central/rev/fd8c95f5ea3a
https://hg.mozilla.org/mozilla-central/rev/598f068edcbc

Status: ASSIGNED → RESOLVED
Closed: 1 year ago
status-firefox97: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 97 Branch
Upstream PR merged by moz-wptsync-bot
You need to log in before you can comment on or make changes to this bug.