1731553 - Add support for "stackTrace" to ConsoleLogEntry and JavascriptLogEntry

Status: RESOLVED FIXED

(Remote Protocol :: WebDriver BiDi, task, P2)

Description

[Henrik Skupin [:whimboo][⌚️UTC+2] (away July 24th - August 16th)]

Once support for ConcoleLogEntry and JavascriptLogEntry has been added we have to also support attaching the stacktrace for trace level ConsoleLogEntry entries, and JavascriptLogEntry.

Comment 1

[Henrik Skupin [:whimboo][⌚️UTC+2] (away July 24th - August 16th)]

Note that via https://github.com/w3c/webdriver-bidi/pull/135 we might not want to add the stackTrace for every ConsoleLogEntry type.

Comment 2

[Henrik Skupin [:whimboo][⌚️UTC+2] (away July 24th - August 16th)]

(In reply to Henrik Skupin (:whimboo) [⌚️UTC+1] from comment #1)

Note that via https://github.com/w3c/webdriver-bidi/pull/135 we might not want to add the stackTrace for every ConsoleLogEntry type.

Based on the merged changes the stacktrace needs to be included for console API calls for the following methods: assert, error, warn and trace.

Comment 3

[Henrik Skupin [:whimboo][⌚️UTC+2] (away July 24th - August 16th)]

Attachment: Bug 1731553 - [remote] Add shared module to handle stack frames.

Comment 4

[Henrik Skupin [:whimboo][⌚️UTC+2] (away July 24th - August 16th)]

Attachment: Bug 1731553 - [webdriver-bidi] Add support for "stackTrace" to "log.entryAdded".

Depends on D133087

Comment 5

[Henrik Skupin [:whimboo][⌚️UTC+2] (away July 24th - August 16th)]

Attachment: Bug 1731553 - [wdspec] Added tests to support stackTrace entries for log.entryAdded.

Depends on D133088

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/4ffae25ab5a9
[remote] Add shared module to handle stack frames. r=webdriver-reviewers,jdescottes
https://hg.mozilla.org/integration/autoland/rev/fd8c95f5ea3a
[webdriver-bidi] Add support for "stackTrace" to "log.entryAdded". r=webdriver-reviewers,jdescottes
https://hg.mozilla.org/integration/autoland/rev/598f068edcbc
[wdspec] Added tests to support stackTrace entries for log.entryAdded. r=webdriver-reviewers,jdescottes

Comment 7

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Created web-platform-tests PR https://github.com/web-platform-tests/wpt/pull/31985 for changes under testing/web-platform/tests

Comment 8

[Norisz Fay [:noriszfay]]

https://hg.mozilla.org/mozilla-central/rev/4ffae25ab5a9
https://hg.mozilla.org/mozilla-central/rev/fd8c95f5ea3a
https://hg.mozilla.org/mozilla-central/rev/598f068edcbc

Comment 9

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Upstream PR merged by moz-wptsync-bot