1731574 - Emit cached log entries when subscribing for `log.entryAdded` events

Status: RESOLVED FIXED

(Remote Protocol :: WebDriver BiDi, task, P2)

Description

[Henrik Skupin [:whimboo][⌚️UTC+1]]

When subscribing to log.entryAdded events we have to emit cached log entries that haven't yet been sent out to the client. While some log entries might be cached by the platform itself, for some others we might have to add cache support on our own. But that needs to be investigated.

Comment 1

[Julian Descottes [:jdescottes]]

In DevTools we have 2 entry points to retrieve cached messages:

• retrieveConsoleEvents for console messages
• Services.console.getMessageArray() for the rest (css messages, error message, platform messages, although I'd need to check if all of those really get cached)

Comment 2

[Julian Descottes [:jdescottes]]

Attachment: Bug 1731574 - [remote] Support cached console api messages in webdriver bidi

Depends on D128117

Comment 3

[Julian Descottes [:jdescottes]]

Attachment: Bug 1731574 - [remote] Support cached console api messages in webdriver bidi

Depends on D132021

Comment 4

[Julian Descottes [:jdescottes]]

Attachment: Bug 1731574 - [remote] Emit cached messages from ConsoleAPIListener

Comment 5

[Julian Descottes [:jdescottes]]

Attachment: Bug 1731574 - [remote] Emit cached messages from ConsoleListener

Depends on D132843

Comment 6

[Julian Descottes [:jdescottes]]

Attachment: Bug 1731574 - [wdspec] Add wdspec tests for log entryAdded event buffer

Depends on D132844

Comment 7

[Julian Descottes [:jdescottes]]

Attachment: Bug 1731574 - [wdspec] Update wdspec tests to create javascript errors without navigation

Depends on D132845

Using a page error built into the URL makes testing difficult with log event buffer enabled

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/e21ddddb74f7
[remote] Emit cached messages from ConsoleAPIListener r=webdriver-reviewers,whimboo
https://hg.mozilla.org/integration/autoland/rev/c3b4ac5546af
[remote] Emit cached messages from ConsoleListener r=webdriver-reviewers,whimboo
https://hg.mozilla.org/integration/autoland/rev/bd35daf060fa
[wdspec] Update wdspec tests to create javascript errors without navigation r=webdriver-reviewers,whimboo
https://hg.mozilla.org/integration/autoland/rev/bb212c328f71
[wdspec] Add wdspec tests for log entryAdded event buffer r=webdriver-reviewers,whimboo,jgraham

Comment 9

[Web Platform Test Sync Bot (Matrix: #interop:mozilla.org)]

Created web-platform-tests PR https://github.com/web-platform-tests/wpt/pull/31952 for changes under testing/web-platform/tests

Comment 10

[Atila Butkovits]

https://hg.mozilla.org/mozilla-central/rev/e21ddddb74f7
https://hg.mozilla.org/mozilla-central/rev/c3b4ac5546af
https://hg.mozilla.org/mozilla-central/rev/bd35daf060fa
https://hg.mozilla.org/mozilla-central/rev/bb212c328f71

Comment 11

[Web Platform Test Sync Bot (Matrix: #interop:mozilla.org)]

Upstream PR merged by moz-wptsync-bot

Comment 12

[Web Platform Test Sync Bot (Matrix: #interop:mozilla.org)]

Upstream PR merged by moz-wptsync-bot