1731583 - Crash in [@ mozalloc_abort | abort | webrtc::RtpPacketizerH264::PacketizeSingleNalu]

Status: RESOLVED DUPLICATE of bug 1654112

(Core :: WebRTC: Audio/Video, defect, P3)

Description

[Calixte Denizet (:calixte)]

Maybe Fission related. (DOMFissionEnabled=1)

Crash report: https://crash-stats.mozilla.org/report/index/b5affbcb-5dd5-4bf4-a783-716510210920

MOZ_CRASH Reason: MOZ_CRASH()

Top 10 frames of crashing thread:

0 libmozglue.dylib mozalloc_abort memory/mozalloc/mozalloc_abort.cpp:33
1 libmozglue.dylib abort memory/mozalloc/mozalloc_abort.cpp:86
2 XUL rtc::FatalMessage::~FatalMessage third_party/libwebrtc/webrtc/rtc_base/checks.cc:69
3 XUL rtc::FatalMessage::~FatalMessage third_party/libwebrtc/webrtc/rtc_base/checks.cc:63
4 XUL webrtc::RtpPacketizerH264::PacketizeSingleNalu third_party/libwebrtc/webrtc/modules/rtp_rtcp/source/rtp_format_h264.cc:296
5 XUL webrtc::RtpPacketizerH264::GeneratePackets third_party/libwebrtc/webrtc/modules/rtp_rtcp/source/rtp_format_h264.cc:178
6 XUL webrtc::RtpPacketizerH264::SetPayloadData third_party/libwebrtc/webrtc/modules/rtp_rtcp/source/rtp_format_h264.cc:170
7 XUL webrtc::RTPSenderVideo::SendVideo third_party/libwebrtc/webrtc/modules/rtp_rtcp/source/rtp_sender_video.cc:387
8 XUL webrtc::RTPSender::SendOutgoingData third_party/libwebrtc/webrtc/modules/rtp_rtcp/source/rtp_sender.cc:454
9 XUL webrtc::ModuleRtpRtcpImpl::SendOutgoingData third_party/libwebrtc/webrtc/modules/rtp_rtcp/source/rtp_rtcp_impl.cc:462

There are 2 crashes (from 1 installation) in nightly 94 with buildid 20210919212908. In analyzing the backtrace, the regression may have been introduced by patch [1] to fix bug 1665776.

[1] https://hg.mozilla.org/mozilla-central/rev?node=3e842ac77d06

Comment 1

[John Lin [:jhlin][:jolin]]

(In reply to Calixte Denizet (:calixte) from comment #0)

There are 2 crashes (from 1 installation) in nightly 94 with buildid 20210919212908. In analyzing the backtrace, the regression may have been introduced by patch [1] to fix bug 1665776.

[1] https://hg.mozilla.org/mozilla-central/rev?node=3e842ac77d06

Yes, it is caused by bug 1665776. Some H.264 platform encoder returns a frame larger than the max payload size and triggers the check. A fix is under development.

Comment 2

[Marco Castelluccio [:marco]]

Set release status flags based on info from the regressing bug 1665776

Comment 3

[Marco Castelluccio [:marco]]

John, did you have a chance to look into this more?

Comment 5

[Paul Adenot (:padenot)]

John, that looks fixed, is that right ?

Comment 6

[Marco Castelluccio [:marco]]

:jib, could you answer the questions for John?

Comment 7

[Jan-Ivar Bruaroey [:jib] (needinfo? me)]

Bug 1654112 removed the offending RTC_CHECK_GE(payload_size_left and no crash reports >95 so this appears fixed.