1731607 - Rewrite browsertime argument parsing code

Status: RESOLVED FIXED

(Testing :: Raptor, enhancement, P1)

Description

[Greg Mierzwinski [:sparky]]

The browsertime argument parsing code needs a bit of work. It can be found here: https://searchfox.org/mozilla-central/source/testing/raptor/raptor/browsertime/base.py#176-374

We should ensure that we have an overwrite-order setup for these like (in order of which is highest priority):
(1) User-input command line flag.
(2) Browsertime args mentioned for a test (i.e. https://searchfox.org/mozilla-central/source/testing/raptor/raptor/tests/custom/browsertime-process-switch.ini#28)
(3) Test-manifest settings.
(4) Default settings.

Furthmore, we seem to be using browsertime_script and browsertime_option interchangeably. We should change this to have the browsertime_script as only the script being used, then use browsertime_options to hold all the options.

Comment 1

[Andrej (:aglavic)]

Attachment: Bug 1731607 - Rewrite browsertime argument parsing code. r?#perftest,sparky!

Made 2 changes:

1. changed browsertime_script to only have the script being used and browsertime_options to be all the options
2. Modified the overwirte order setup to the priorty order in the bug to be(highest to lowest priority) user(1), browsertimeargs(2), testmanifest(3), defaultsettings(4)

For 2) this change involved changing the order the arguments were initialized and adding a section that allowed you to overwtite browsertimeargs settings, testmanifest settings and defaultsettings with commandline settings

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/ec65b384c2c3
Rewrite browsertime argument parsing code. r=sparky,perftest-reviewers

Comment 3

[Cristian Tuns]

https://hg.mozilla.org/mozilla-central/rev/ec65b384c2c3