1731793 - error message when closing browser toolbox (after using node picker?)

Status: RESOLVED FIXED

(DevTools :: Inspector, defect)

Description

[Nicolas Chevobbe [:nchevobbe]]

here's the message I see in the terminal:

TypeError: (destructured parameter) is undefined: _onInspectorFrontDestroyed@resource://devtools/client/inspector/node-picker.js:104:35
_emit@resource://devtools/shared/event-emitter.js:244:34
emit@resource://devtools/shared/event-emitter.js:190:18
emit@resource://devtools/shared/event-emitter.js:342:18
unmanage@resource://devtools/shared/protocol/Front.js:170:37
destroy@resource://devtools/shared/protocol/Pool.js:184:14
baseFrontClassDestroy@resource://devtools/shared/protocol/Front.js:110:13
destroy@resource://devtools/shared/protocol/Front.js:74:10
destroy@resource://devtools/client/fronts/inspector.js:113:11
_destroyTarget@resource://devtools/client/fronts/targets/target-mixin.js:641:17

This is triggered by https://searchfox.org/mozilla-central/rev/50c3cf7a3c931409b54efa009795b69c19383541/devtools/client/inspector/node-picker.js#104 , because we're missing the second parameter and we try to destructure it.
It probably comes from this callback https://searchfox.org/mozilla-central/rev/50c3cf7a3c931409b54efa009795b69c19383541/devtools/client/inspector/node-picker.js#137

Comment 1

[Nicolas Chevobbe [:nchevobbe]]

Attachment: Bug 1731793 - [devtools] Fix node picker error when closing browser toolbox. r=ochameau.

onInspectorFrontDestroyed was throwing because when it
is called from the destroy callback of watchFronts, it
doesn't get a second argument, and the destructuring fails.
This patch defaults the second parameter to an empty object
in order to avoid this.

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/0cab7f09323c
[devtools] Fix node picker error when closing browser toolbox. r=ochameau.

Comment 3

[Narcis Beleuzu [:NarcisB]]

https://hg.mozilla.org/mozilla-central/rev/0cab7f09323c

Comment 4

[BugBot [:suhaib / :marco/ :calixte]]

Set release status flags based on info from the regressing bug 1729925