make cumulative and extra resolution make sense
Categories
(Core :: Panning and Zooming, enhancement)
Tracking
()
Tracking | Status | |
---|---|---|
firefox94 | --- | fixed |
People
(Reporter: tnikkel, Assigned: tnikkel)
References
Details
Attachments
(3 files)
Assignee | ||
Comment 1•3 years ago
|
||
extra resolution ends up being 1 / transform to ancestor scale, which doesn't make much sense. We don't have extra resolution anymore with webrender (see the bottom of the commit msg of https://phabricator.services.mozilla.com/D124905 for more details on that). So we want to get rid of extra resolution, but it's value makes some calculations have the correct numerical value that we want (see commit msg of https://phabricator.services.mozilla.com/D126304 for some details on that).
So basically in this bug we are going to add a new field to FrameMetrics/RepaintRequest for the transform to ancestor scale, and then use it instead of extra resolution. And then bug 1729784 will remove extra resolution (since I had that bug filed already).
The net effect should be code that makes more sense, but no functional change.
Assignee | ||
Comment 2•3 years ago
|
||
Depends on D126304
Updated•3 years ago
|
Assignee | ||
Comment 3•3 years ago
|
||
Some explanation in https://phabricator.services.mozilla.com/D126304
This should have no functional change since mExtraResolution = 1 / mTransformToAncestorScale.
Depends on D126305
Assignee | ||
Comment 4•3 years ago
|
||
Depends on D126305
Pushed by tnikkel@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/5b25ba729a21 Add transform to ancestor scale to FrameMetrics/RepaintRequest. r=botond https://hg.mozilla.org/integration/autoland/rev/743007ddfecc Allow ViewAs for ScaleFactors2D coming from unknown units. r=botond https://hg.mozilla.org/integration/autoland/rev/8c360067b648 Use mTransformToAncestorScale instead of mExtraResolution in DisplayportPixelsPerCSSPixel. r=botond
Comment 6•3 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/5b25ba729a21
https://hg.mozilla.org/mozilla-central/rev/743007ddfecc
https://hg.mozilla.org/mozilla-central/rev/8c360067b648
Description
•