Closed Bug 1731994 Opened 2 months ago Closed 2 months ago

Fortify code around `ContentPermissionRequestBase`

Categories

(Core :: DOM: Copy & Paste and Drag & Drop, enhancement)

enhancement

Tracking

()

RESOLVED FIXED

People

(Reporter: mbrodesser, Assigned: mbrodesser)

References

(Blocks 1 open bug)

Details

Attachments

(8 files)

48 bytes, text/x-phabricator-request
Details | Review
48 bytes, text/x-phabricator-request
Details | Review
48 bytes, text/x-phabricator-request
Details | Review
48 bytes, text/x-phabricator-request
Details | Review
48 bytes, text/x-phabricator-request
Details | Review
48 bytes, text/x-phabricator-request
Details | Review
48 bytes, text/x-phabricator-request
Details | Review
48 bytes, text/x-phabricator-request
Details | Review

It's partially undocumented and lacks const-correctness.

Changing severity to N/A because it's an enhancement.

Severity: -- → N/A
Pushed by mbrodesser@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/9ba235034c43
part 1) const-qualify some members of `ContentPermissionRequestBase`. r=edgar
https://hg.mozilla.org/integration/autoland/rev/5dece26f14db
part 2) Add some documentation to `ContentPermissionRequestBase`'s constructor. r=edgar
https://hg.mozilla.org/integration/autoland/rev/a4d5bf7a3369
part 3) Extend documentation of `ContentPermissionRequestBase`'s constructor. r=edgar
https://hg.mozilla.org/integration/autoland/rev/d8ff1ee14949
part 4) Declare more methods around `ContentPermissionRequestBase` `const`. r=edgar

Because of PermissionDelegateHandler::GetPermissionDelegateInfo.

Pushed by mbrodesser@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/dbc8f1bccbd1
part 5) Rename `ContentPermissionRequestParent::mMaybeUnsafePermissionDelegate` to `ContentPermissionRequestParent::mIsRequestDelegatedToUnsafeThirdParty`. r=johannh
Pushed by mbrodesser@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/0d28bc7c284d
part 6) Update `sPermissionsMap`'s documentation. r=baku DONTBUILD
https://hg.mozilla.org/integration/autoland/rev/e4dc3e02f997
part 7) Update documentation of `nsIContentPermissionPrompt`. r=edgar DONTBUILD
Pushed by mbrodesser@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/73ec90bea3c1
part 8) Rename `nsIContentPermissionRequest`'s `isHandlingUserInput` to `hasValidTransientUserGestureActivation`. r=edgar
Status: NEW → RESOLVED
Closed: 2 months ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.