1731994 - Fortify code around `ContentPermissionRequestBase`

Status: RESOLVED FIXED

(Core :: DOM: Copy & Paste and Drag & Drop, enhancement)

Description

[Mirko Brodesser (:mbrodesser) -- not reading bugmails currently]

It's partially undocumented and lacks const-correctness.

Comment 1

[Mirko Brodesser (:mbrodesser) -- not reading bugmails currently]

Changing severity to N/A because it's an enhancement.

Comment 2

[Mirko Brodesser (:mbrodesser) -- not reading bugmails currently]

Attachment: Bug 1731994: part 1) const-qualify some members of `ContentPermissionRequestBase`. r=edgar

Comment 3

[Mirko Brodesser (:mbrodesser) -- not reading bugmails currently]

Attachment: Bug 1731994: part 2) Add some documentation to `ContentPermissionRequestBase`'s constructor. r=edgar

Depends on D126337

Comment 4

[Mirko Brodesser (:mbrodesser) -- not reading bugmails currently]

Attachment: Bug 1731994: part 3) Extend documentation of `ContentPermissionRequestBase`'s constructor. r=edgar

Comment 5

[Mirko Brodesser (:mbrodesser) -- not reading bugmails currently]

Attachment: Bug 1731994: part 4) Declare more methods around `ContentPermissionRequestBase` `const`. r=edgar

Depends on D126349

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/9ba235034c43
part 1) const-qualify some members of `ContentPermissionRequestBase`. r=edgar
https://hg.mozilla.org/integration/autoland/rev/5dece26f14db
part 2) Add some documentation to `ContentPermissionRequestBase`'s constructor. r=edgar
https://hg.mozilla.org/integration/autoland/rev/a4d5bf7a3369
part 3) Extend documentation of `ContentPermissionRequestBase`'s constructor. r=edgar
https://hg.mozilla.org/integration/autoland/rev/d8ff1ee14949
part 4) Declare more methods around `ContentPermissionRequestBase` `const`. r=edgar

Comment 7

[Mirko Brodesser (:mbrodesser) -- not reading bugmails currently]

Attachment: Bug 1731994: part 5) Rename `ContentPermissionRequestParent::mMaybeUnsafePermissionDelegate` to `ContentPermissionRequestParent::mIsRequestDelegatedToUnsafeThirdParty`. r=johannh

This seems clearer. "Is" is more precise then "maybe".

Comment 8

[Sandor Molnar[:smolnar]]

https://hg.mozilla.org/mozilla-central/rev/9ba235034c43
https://hg.mozilla.org/mozilla-central/rev/5dece26f14db
https://hg.mozilla.org/mozilla-central/rev/a4d5bf7a3369
https://hg.mozilla.org/mozilla-central/rev/d8ff1ee14949

Comment 9

[Mirko Brodesser (:mbrodesser) -- not reading bugmails currently]

Attachment: Bug 1731994: part 6) Update `sPermissionsMap`'s documentation. r=baku

Because of PermissionDelegateHandler::GetPermissionDelegateInfo.

Comment 10

[Mirko Brodesser (:mbrodesser) -- not reading bugmails currently]

Attachment: Bug 1731994: part 7) Update documentation of `nsIContentPermissionPrompt`. r=edgar

Comment 11

[Mirko Brodesser (:mbrodesser) -- not reading bugmails currently]

Attachment: Bug 1731994: part 8) Rename `nsIContentPermissionRequest`'s `isHandlingUserInput` to `hasValidTransientUserGestureActivation`. r=edgar

It's more accurate.

Comment 12

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/dbc8f1bccbd1
part 5) Rename `ContentPermissionRequestParent::mMaybeUnsafePermissionDelegate` to `ContentPermissionRequestParent::mIsRequestDelegatedToUnsafeThirdParty`. r=johannh

Comment 13

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/0d28bc7c284d
part 6) Update `sPermissionsMap`'s documentation. r=baku DONTBUILD
https://hg.mozilla.org/integration/autoland/rev/e4dc3e02f997
part 7) Update documentation of `nsIContentPermissionPrompt`. r=edgar DONTBUILD

Comment 14

[Natalia Csoregi [:nataliaCs]]

https://hg.mozilla.org/mozilla-central/rev/dbc8f1bccbd1
https://hg.mozilla.org/mozilla-central/rev/0d28bc7c284d
https://hg.mozilla.org/mozilla-central/rev/e4dc3e02f997

Comment 15

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/73ec90bea3c1
part 8) Rename `nsIContentPermissionRequest`'s `isHandlingUserInput` to `hasValidTransientUserGestureActivation`. r=edgar

Comment 16

[Cristian Tuns]

https://hg.mozilla.org/mozilla-central/rev/73ec90bea3c1