Closed
Bug 1731994
Opened 3 years ago
Closed 3 years ago
Fortify code around `ContentPermissionRequestBase`
Categories
(Core :: DOM: Copy & Paste and Drag & Drop, enhancement)
Core
DOM: Copy & Paste and Drag & Drop
Tracking
()
RESOLVED
FIXED
People
(Reporter: mbrodesser-Igalia, Assigned: mbrodesser-Igalia)
References
Details
Attachments
(8 files)
|
48 bytes,
text/x-phabricator-request
|
Details | Review | |
|
Bug 1731994: part 2) Add some documentation to `ContentPermissionRequestBase`'s constructor. r=edgar
48 bytes,
text/x-phabricator-request
|
Details | Review | |
|
48 bytes,
text/x-phabricator-request
|
Details | Review | |
|
48 bytes,
text/x-phabricator-request
|
Details | Review | |
|
48 bytes,
text/x-phabricator-request
|
Details | Review | |
|
48 bytes,
text/x-phabricator-request
|
Details | Review | |
|
48 bytes,
text/x-phabricator-request
|
Details | Review | |
|
48 bytes,
text/x-phabricator-request
|
Details | Review |
It's partially undocumented and lacks const-correctness.
|
Assignee | |
Comment 1•3 years ago
|
||
Changing severity to N/A because it's an enhancement.
Severity: -- → N/A
|
|
Assignee | |
Comment 2•3 years ago
|
||
|
|
Assignee | |
Comment 3•3 years ago
|
||
Depends on D126337
|
|
Assignee | |
Comment 4•3 years ago
|
||
|
|
Assignee | |
Comment 5•3 years ago
|
||
Depends on D126349
|
|
Assignee | |
Updated•3 years ago
|
Keywords: leave-open
Pushed by mbrodesser@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/9ba235034c43 part 1) const-qualify some members of `ContentPermissionRequestBase`. r=edgar https://hg.mozilla.org/integration/autoland/rev/5dece26f14db part 2) Add some documentation to `ContentPermissionRequestBase`'s constructor. r=edgar https://hg.mozilla.org/integration/autoland/rev/a4d5bf7a3369 part 3) Extend documentation of `ContentPermissionRequestBase`'s constructor. r=edgar https://hg.mozilla.org/integration/autoland/rev/d8ff1ee14949 part 4) Declare more methods around `ContentPermissionRequestBase` `const`. r=edgar
|
|
Assignee | |
Comment 7•3 years ago
|
||
This seems clearer. "Is" is more precise then "maybe".
|
||
Comment 8•3 years ago
|
||
| bugherder | ||
|
|
Assignee | |
Comment 9•3 years ago
|
||
Because of PermissionDelegateHandler::GetPermissionDelegateInfo.
|
|
Assignee | |
Comment 10•3 years ago
|
||
|
|
Assignee | |
Comment 11•3 years ago
|
||
It's more accurate.
|
||
Comment 12•3 years ago
|
||
Pushed by mbrodesser@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/dbc8f1bccbd1 part 5) Rename `ContentPermissionRequestParent::mMaybeUnsafePermissionDelegate` to `ContentPermissionRequestParent::mIsRequestDelegatedToUnsafeThirdParty`. r=johannh
|
|
||
Comment 13•3 years ago
|
||
Pushed by mbrodesser@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/0d28bc7c284d part 6) Update `sPermissionsMap`'s documentation. r=baku DONTBUILD https://hg.mozilla.org/integration/autoland/rev/e4dc3e02f997 part 7) Update documentation of `nsIContentPermissionPrompt`. r=edgar DONTBUILD
|
||
Comment 14•3 years ago
|
||
| bugherder | ||
|
|
||
Comment 15•3 years ago
|
||
Pushed by mbrodesser@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/73ec90bea3c1 part 8) Rename `nsIContentPermissionRequest`'s `isHandlingUserInput` to `hasValidTransientUserGestureActivation`. r=edgar
|
||
Comment 16•3 years ago
|
||
| bugherder | ||
|
|
Assignee | |
Updated•3 years ago
|
Status: NEW → RESOLVED
Closed: 3 years ago
Resolution: --- → FIXED
|
||
Updated•3 years ago
|
Keywords: leave-open
You need to log in
before you can comment on or make changes to this bug.
Description
•