Closed Bug 1732044 Opened 3 years ago Closed 3 years ago

[wpt-sync] Sync PR 30877 - Add clearance correctly past fragmented floats.

Categories

(Core :: Layout, task, P4)

Product:
Core
Component:
Layout
Type:
task

Tracking

()

Status:
RESOLVED FIXED
Milestone:
95 Branch
Tracking Flags:
Tracking Status
firefox95 --- fixed

People

(Reporter: mozilla.org, Unassigned)

References

(Blocks 1 open bug,
URL
)

Details

(Whiteboard: [wptsync downstream])

Sync web-platform-tests PR 30877 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/30877
Details from upstream follow.

Morten Stenshorne <mstensho@chromium.org> wrote:

Add clearance correctly past fragmented floats.

It used to be possible to squeeze in a zero-height child (in-flow or
floated) at the bottom of a fragmentainer with fragmented floats, even
if the child should have clearance applied.

So, just adding an exclusion that goes all the way to the bottom of the
fragmentainer won't do. That part ensures that containers are stretched
correctly, but we actually need some additional logic to make sure that
we don't attempt to insert content that should be cleared past the
current fragmentainer.

Bug: 829028
Change-Id: Ib9363936d1602bff7dc5ecb0e36eecdf62c91270
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3170395
Reviewed-by: Alison Maher \<almaher@microsoft.com>
Reviewed-by: Ian Kilpatrick \<ikilpatrick@chromium.org>
Commit-Queue: Morten Stenshorne \<mstensho@chromium.org>
Cr-Commit-Position: refs/heads/main@{#923287}

Component: web-platform-tests → Layout
Product: Testing → Core

CI Results

Ran 7 Firefox configurations based on mozilla-central, and Firefox, Chrome, and Safari on GitHub CI

Total 5 tests

Status Summary

Firefox

PASS: 2
FAIL: 3

Chrome

PASS: 5

Safari

PASS: 4
FAIL: 1

Links

Gecko CI (Treeherder)
GitHub PR Head
GitHub PR Base

Details

Firefox-only Failures

/css/css-break/float-001.html: FAIL
/css/css-break/float-003.html: FAIL

New Tests That Don't Pass

/css/css-break/float-001.html: FAIL (Chrome: PASS, Safari: PASS)
/css/css-break/float-003.html: FAIL (Chrome: PASS, Safari: PASS)
/css/css-break/float-004.html: FAIL (Chrome: PASS, Safari: FAIL)

Pushed by wptsync@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/1f917eea4e00
[wpt PR 30877] - Add clearance correctly past fragmented floats., a=testonly
https://hg.mozilla.org/integration/autoland/rev/c180c7fbeb19
[wpt PR 30877] - Update wpt metadata, a=testonly
Pushed by wptsync@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/47062a8189a9
[wpt PR 30877] - Add clearance correctly past fragmented floats., a=testonly
https://hg.mozilla.org/integration/autoland/rev/7db1c68e2b6a
[wpt PR 30877] - Update wpt metadata, a=testonly

https://hg.mozilla.org/mozilla-central/rev/47062a8189a9
https://hg.mozilla.org/mozilla-central/rev/7db1c68e2b6a

Status: NEW → RESOLVED
Closed: 3 years ago
status-firefox95: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 95 Branch
You need to log in before you can comment on or make changes to this bug.