1732080 - Permanent css/css-pseudo/backdrop-animate-002.html == http://web-platform.test:8000/css/css-pseudo/backdrop-animate-002-ref.html and selection-background-painting-order.html unexpected results when Gecko 94 merges to Beta on 2021-10-04

Status: VERIFIED FIXED

(Core :: CSS Parsing and Computation, defect)

Description

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

Test got added in bug 1729462.

• central-as-beta simulation
• How to run these simulations
• Failure log

TEST-UNEXPECTED-PASS | /css/css-pseudo/backdrop-animate-002.html | Testing http://web-platform.test:8000/css/css-pseudo/backdrop-animate-002.html == http://web-platform.test:8000/css/css-pseudo/backdrop-animate-002-ref.html
TEST-UNEXPECTED-FAIL | /css/css-pseudo/selection-background-painting-order.html | Testing http://web-platform.test:8000/css/css-pseudo/selection-background-painting-order.html == http://web-platform.test:8000/css/css-pseudo/selection-background-painting-order-ref1.html

Comment 1

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

Also as part of the web platform tests (non-reftests): TEST-UNEXPECTED-ERROR | /css/css-pseudo/backdrop-animate.html | TypeError: target.showModal is not a function

Comment 2

[Emilio Cobos Álvarez (:emilio)]

These probably need to enable dom.dialog_element.enabled to have consistent results.

Comment 3

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

Attachment: WIP: Bug 1732080 - adjust results of css-pseudo backdrop tests for release and beta. DONTBUILD

Bug 1729462 added the animate tests which depends on which depends on the
preference dom.dialog_element.enabled being set to true.

Bug 1728531 the selection one. Reason for failure is still unknown.

Comment 4

[Emilio Cobos Álvarez (:emilio)]

Attachment: Bug 1732080 - Enable dialog in two tests that use it. r=sefeng

Comment 5

[Emilio Cobos Álvarez (:emilio)]

The selection one is because the web font fails to load on nightly because it gets sanitized:

downloadable font: Layout: bad start coverage index. (font-family: "CSSTest" style:normal weight:400 stretch:100 src index:0) source: http://wpt.live/fonts/CSSTest/csstest-basic-italic.ttf
downloadable font: GDEF: Bad coverage table (font-family: "CSSTest" style:normal weight:400 stretch:100 src index:0) source: http://wpt.live/fonts/CSSTest/csstest-basic-italic.ttf
downloadable font: GDEF: Invalid attachment list (font-family: "CSSTest" style:normal weight:400 stretch:100 src index:0) source: http://wpt.live/fonts/CSSTest/csstest-basic-italic.ttf
downloadable font: GDEF: Failed to parse table (font-family: "CSSTest" style:normal weight:400 stretch:100 src index:0) source: http://wpt.live/fonts/CSSTest/csstest-basic-italic.ttf
downloadable font: rejected by sanitizer (font-family: "CSSTest" style:normal weight:400 stretch:100 src index:0) source: http://wpt.live/fonts/CSSTest/csstest-basic-italic.ttf

Not sure what's the best path forward there. Should we just fix the font?

Comment 6

[Cristina Cozmuta (:CrissCozmuta)]

We imported patch D126594 - but there are still some tests that were not fixed : https://treeherder.mozilla.org/jobs?repo=try&selectedTaskRun=NN6Z5wcITxqhbbYPutrV-g.0&resultStatus=testfailed%2Cbusted%2Cexception&revision=b4ad91bf0d12f95533bef8333020d2d2e04e14a3&searchStr=web-platf%2Creftest
Please see failure log : https://treeherder.mozilla.org/logviewer?job_id=352700632&repo=try&lineNumber=16632

Comment 7

[Emilio Cobos Álvarez (:emilio)]

Yes, that's comment 5.

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/60f70fb44696
Enable dialog in two tests that use it. r=sefeng

Comment 9

[Intermittent Failures Robot]

1 failures in 2873 pushes (0.0 failures/push) were associated with this bug in the last 7 days.

Repository breakdown:

• try: 1

Platform and build breakdown:

• android-em-7-0-x86_64-shippable-lite-qr: 1
  • opt: 1

For more details, see:
https://treeherder.mozilla.org/intermittent-failures/bugdetails?bug=1732080&startday=2021-09-20&endday=2021-09-26&tree=all

Comment 10

[Cristian Tuns]

https://hg.mozilla.org/mozilla-central/rev/60f70fb44696

Comment 11

[Delan Azabani]

(In reply to Emilio Cobos Álvarez (:emilio) from comment #5)

Not sure what's the best path forward there. Should we just fix the font?

It looks like this font was added by :jtd back in 2010 and not updated since, though I’m not sure if they are still around to comment. I don’t know enough about fonts or the new(?) sanitiser to be sure, but if the fonts are clearly malformed, I think it’s a good idea to try and fix them.

If that ends up being impractical, we can find or add a new font in WPT for <css/css-pseudo/selection-background-painting-order.html>. I think my test only requires that the font has a character with ink overflow on both left and right (ref1, ref2).

Comment 12

[Emilio Cobos Álvarez (:emilio)]

Attachment: Bug 1732080 - Fix csstest-basic-italic to not trip the font sanitizer. r=jfkthame

Generated by just importing+exporting from fontforge. It's only used in
three tests that just need ink overflow on both sides and so on, which
this patch preserves.

Comment 13

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/cdc9883721e1
Fix csstest-basic-italic to not trip the font sanitizer. r=jfkthame

Comment 14

[Atila Butkovits]

https://hg.mozilla.org/mozilla-central/rev/cdc9883721e1

Comment 15

[Web Platform Test Sync Bot (Matrix: #interop:mozilla.org)]

Created web-platform-tests PR https://github.com/web-platform-tests/wpt/pull/31013 for changes under testing/web-platform/tests

Comment 16

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

Verified fixed in today's central-as-beta simulation.

Comment 17

[Web Platform Test Sync Bot (Matrix: #interop:mozilla.org)]

Upstream PR merged by moz-wptsync-bot