Closed Bug 1732151 Opened 8 months ago Closed 2 months ago

Remove vendorShortName and migrate existing strings to Fluent

Categories

(Core :: General, task)

task

Tracking

()

RESOLVED FIXED
100 Branch
Tracking Status
firefox100 --- fixed

People

(Reporter: flod, Assigned: eemeli)

References

(Blocks 1 open bug)

Details

Attachments

(2 files)

https://searchfox.org/mozilla-central/search?q=vendorShortName&path=

We only have one user for vendorShortName  defined in brand.properties, so we should move that infobar over to Fluent

https://searchfox.org/mozilla-central/rev/235982cdb78d0dc3ab4e48326b084ce087302cab/browser/locales/en-US/chrome/browser/browser.properties#656-659

As for the vendorShorName defined in brand.dtd for mobile, it would be nice to remove it as well, but it's not as important.

Flod, could you recommend an FTL file for the strings that would need to be migrated for this? Just browser.ftl, or something else? The closest other string to this that I can find is here.

Flags: needinfo?(francesco.lodolo)

browser.ftl sounds reasonable to me, as I don't think there's value in having a separate file for infobars and such.

Flags: needinfo?(francesco.lodolo)
Assignee: nobody → earo
Status: NEW → ASSIGNED

The dataReportingNotification is the last place where the .properties
vendorShortName is used. As notifications already support Fluent,
porting this to use Fluent as well seems pretty strqaightforward.

At this point, no code in mozilla-central references these.
In comms-central, the string is still used, but provided there
by local brand.properties and brand.dtd files.

Depends on D141860

Pushed by flodolo@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/2f9e4aaaa8d2
Migrate dataReportingNotification strings to Fluent. r=preferences-reviewers,fluent-reviewers,flod
https://hg.mozilla.org/integration/autoland/rev/0319242f614e
Remove unused vendorShortName from brand.properties and brand.dtd. r=flod
Status: ASSIGNED → RESOLVED
Closed: 2 months ago
Resolution: --- → FIXED
Target Milestone: --- → 100 Branch
You need to log in before you can comment on or make changes to this bug.