Add profiler markers for runUiThreadCallback
Categories
(GeckoView :: General, task, P3)
Tracking
(Not tracked)
People
(Reporter: mcomella, Unassigned)
Details
When org.mozilla.gecko.GeckoThread.runUiThreadCallback shows up on the main thread in a profile, doesn't call into other functions so it's difficult to answer essential perf questions like, "What is it executing?", "Does that need to happen now?", and "What caused this method to be running now?" It also makes it difficult for the perf team to identify the root cause of perf issues with this code, causing imprecise perf bug reports that require further investigation. For example, see bug 1693911 and this recent profile we took of opening the tabs tray: https://share.firefox.dev/3AzciFK
I'd suggest adding profiler markers that explain what runUiThreadCallback is executing.
If there is another way to answer "What is runUiThreadCallback" executing from a profile, perhaps this isn't necessary – please let me know how we can do that! :)
|
||
Updated•4 years ago
|
|
|
||
Comment 1•4 years ago
|
||
If I understand correctly runUiThreadCallback is running native callbacks on the UI thread, you should be able to see what is happening looking at the native frames, is that not enough?
|
Reporter | |
Comment 2•4 years ago
|
||
Is that by including the AndroidUI thread in the profiler options? I had forgotten about that. If so, I think that's probably good enough and I can reopen if it becomes a problem. Markers would be more specific but maybe it's not worth the implementation effort.
If that's not what you meant, please reopen!
Description
•