Closed Bug 1732161 Opened 4 months ago Closed 3 months ago

Track and report CC reason to profiler

Categories

(Core :: XPCOM, defect, P3)

defect

Tracking

()

RESOLVED FIXED
95 Branch
Tracking Status
firefox95 --- fixed

People

(Reporter: sfink, Assigned: sfink)

References

Details

Attachments

(6 files)

I would like to record the reason that a CC is triggered in the profiler.

And now that I've written the patch, I see this is basically a dupe of the 10 year old bug 710499! (Except that was for telemetry, which I was considering as a followup.) That bug suggests that a single reason might not be enough; it might be better to track the full set of reasons for a given CC. Which coincidentally was just suggested today by jonco for GC reasons as well.

See Also: → 710499
Assignee: nobody → sphink
Status: NEW → ASSIGNED
Attachment #9242545 - Attachment description: Bug 1732161 - Track CCReason for all cycle collections → Bug 1732161 - Track CCReason for all cycle collections (replacing ccType)
Pushed by sfink@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/b3e894d590d9
Add profiler marker for core part of CC r=smaug,gerald
https://hg.mozilla.org/integration/autoland/rev/0cbf901cab8b
Pass through explicit ccIsManual to reduce usage of ccType r=smaug
https://hg.mozilla.org/integration/autoland/rev/b339e54078d7
Remove unused ccType from ShouldMergeZones r=smaug
https://hg.mozilla.org/integration/autoland/rev/d83b36b92051
Replace bools with CCReasons for the scheduler control variables. r=smaug
https://hg.mozilla.org/integration/autoland/rev/a5a2c9c53340
Track CCReason for all cycle collections (replacing ccType) r=smaug
https://hg.mozilla.org/integration/autoland/rev/88dbe1a7478c
Add the CC reason to CC profile markers r=gerald
Pushed by sfink@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/50d17b172185
Add profiler marker for core part of CC r=smaug,gerald
https://hg.mozilla.org/integration/autoland/rev/6acb82c0ac3c
Pass through explicit ccIsManual to reduce usage of ccType r=smaug
https://hg.mozilla.org/integration/autoland/rev/84787a58a428
Remove unused ccType from ShouldMergeZones r=smaug
https://hg.mozilla.org/integration/autoland/rev/fb1838a152f2
Replace bools with CCReasons for the scheduler control variables. r=smaug
https://hg.mozilla.org/integration/autoland/rev/d24b8450b7ed
Track CCReason for all cycle collections (replacing ccType) r=smaug
https://hg.mozilla.org/integration/autoland/rev/7271b938e71a
Add the CC reason to CC profile markers r=gerald
Pushed by sfink@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/67d81f8f413e
Add profiler marker for core part of CC r=smaug,gerald
https://hg.mozilla.org/integration/autoland/rev/49dcac272f05
Pass through explicit ccIsManual to reduce usage of ccType r=smaug
https://hg.mozilla.org/integration/autoland/rev/76c21ec8ffb6
Remove unused ccType from ShouldMergeZones r=smaug
https://hg.mozilla.org/integration/autoland/rev/98eaff0d5124
Replace bools with CCReasons for the scheduler control variables. r=smaug
https://hg.mozilla.org/integration/autoland/rev/aed63de28354
Track CCReason for all cycle collections (replacing ccType) r=smaug
https://hg.mozilla.org/integration/autoland/rev/766a1bc74001
Add the CC reason to CC profile markers r=gerald
Pushed by sfink@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/3bb43ee4a954
Add profiler marker for core part of CC r=smaug,gerald
https://hg.mozilla.org/integration/autoland/rev/9c2d667cad6d
Pass through explicit ccIsManual to reduce usage of ccType r=smaug
https://hg.mozilla.org/integration/autoland/rev/620d1123ade3
Remove unused ccType from ShouldMergeZones r=smaug
https://hg.mozilla.org/integration/autoland/rev/027f4bc5efe6
Replace bools with CCReasons for the scheduler control variables. r=smaug
https://hg.mozilla.org/integration/autoland/rev/9a0e9dbfe524
Track CCReason for all cycle collections (replacing ccType) r=smaug
https://hg.mozilla.org/integration/autoland/rev/87d6b8574dd8
Add the CC reason to CC profile markers r=gerald

The 4th try is sticking so far...

Flags: needinfo?(sphink)
You need to log in before you can comment on or make changes to this bug.