1732161 - Track and report CC reason to profiler

Status: RESOLVED FIXED

(Core :: XPCOM, defect, P3)

Description

[Steve Fink [:sfink] [:s:]]

I would like to record the reason that a CC is triggered in the profiler.

And now that I've written the patch, I see this is basically a dupe of the 10 year old bug 710499! (Except that was for telemetry, which I was considering as a followup.) That bug suggests that a single reason might not be enough; it might be better to track the full set of reasons for a given CC. Which coincidentally was just suggested today by jonco for GC reasons as well.

Comment 1

[Steve Fink [:sfink] [:s:]]

Attachment: Bug 1732161 - Add profiler marker for core part of CC

Comment 2

[Steve Fink [:sfink] [:s:]]

Attachment: Bug 1732161 - Track CCReason for all cycle collections (replacing ccType)

Comment 3

[Steve Fink [:sfink] [:s:]]

Attachment: Bug 1732161 - Pass through explicit ccIsManual to reduce usage of ccType

Comment 4

[Steve Fink [:sfink] [:s:]]

Attachment: Bug 1732161 - Remove unused ccType from ShouldMergeZones

Comment 5

[Steve Fink [:sfink] [:s:]]

Attachment: Bug 1732161 - Replace bools with CCReasons for the scheduler control variables.

Comment 6

[Steve Fink [:sfink] [:s:]]

Attachment: Bug 1732161 - Add the CC reason to CC profile markers

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/b3e894d590d9
Add profiler marker for core part of CC r=smaug,gerald
https://hg.mozilla.org/integration/autoland/rev/0cbf901cab8b
Pass through explicit ccIsManual to reduce usage of ccType r=smaug
https://hg.mozilla.org/integration/autoland/rev/b339e54078d7
Remove unused ccType from ShouldMergeZones r=smaug
https://hg.mozilla.org/integration/autoland/rev/d83b36b92051
Replace bools with CCReasons for the scheduler control variables. r=smaug
https://hg.mozilla.org/integration/autoland/rev/a5a2c9c53340
Track CCReason for all cycle collections (replacing ccType) r=smaug
https://hg.mozilla.org/integration/autoland/rev/88dbe1a7478c
Add the CC reason to CC profile markers r=gerald

Comment 8

[Atila Butkovits]

Backed out for causing assertion failures in CCGCScheduler.h.

Backout link: https://hg.mozilla.org/integration/autoland/rev/9862759294b3bb79db84a5a9ebb2ce9854aecd9c

Push with failures: https://treeherder.mozilla.org/jobs?repo=autoland&selectedTaskRun=OavpeBaYQ5iGsvrgfL7QSw.0&resultStatus=testfailed%2Cbusted%2Cexception%2Cretry%2Cusercancel&revision=88dbe1a7478c82c0c93830cedb88d134c3392382

Failure log: https://treeherder.mozilla.org/logviewer?job_id=353655959&repo=autoland&lineNumber=32185

Comment 9

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/50d17b172185
Add profiler marker for core part of CC r=smaug,gerald
https://hg.mozilla.org/integration/autoland/rev/6acb82c0ac3c
Pass through explicit ccIsManual to reduce usage of ccType r=smaug
https://hg.mozilla.org/integration/autoland/rev/84787a58a428
Remove unused ccType from ShouldMergeZones r=smaug
https://hg.mozilla.org/integration/autoland/rev/fb1838a152f2
Replace bools with CCReasons for the scheduler control variables. r=smaug
https://hg.mozilla.org/integration/autoland/rev/d24b8450b7ed
Track CCReason for all cycle collections (replacing ccType) r=smaug
https://hg.mozilla.org/integration/autoland/rev/7271b938e71a
Add the CC reason to CC profile markers r=gerald

Comment 10

[Narcis Beleuzu [:NarcisB]]

Backed out for build bustages on nsCycleCollectionParticipant.h

Backout link: https://hg.mozilla.org/integration/autoland/rev/d5128422f25a2cad707e2571f300c0240b9828d7
Log link: https://treeherder.mozilla.org/logviewer?job_id=354441549&repo=autoland&lineNumber=53783

Comment 11

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/67d81f8f413e
Add profiler marker for core part of CC r=smaug,gerald
https://hg.mozilla.org/integration/autoland/rev/49dcac272f05
Pass through explicit ccIsManual to reduce usage of ccType r=smaug
https://hg.mozilla.org/integration/autoland/rev/76c21ec8ffb6
Remove unused ccType from ShouldMergeZones r=smaug
https://hg.mozilla.org/integration/autoland/rev/98eaff0d5124
Replace bools with CCReasons for the scheduler control variables. r=smaug
https://hg.mozilla.org/integration/autoland/rev/aed63de28354
Track CCReason for all cycle collections (replacing ccType) r=smaug
https://hg.mozilla.org/integration/autoland/rev/766a1bc74001
Add the CC reason to CC profile markers r=gerald

Comment 12

[Cristina Cozmuta (:CrissCozmuta)]

Backed out for causing linux base toolchains bustages. CLOSED TREE

Backout link : https://hg.mozilla.org/integration/autoland/rev/f58a783bb009d22df31ec1965052cfe8537cbfe4

Push with failures : https://treeherder.mozilla.org/jobs?repo=autoland&resultStatus=testfailed%2Cbusted%2Cexception%2Crunnable&revision=e9857ac8b3aed82c29e8c5f0c9a0ce94526042d8&searchStr=linux&selectedTaskRun=Z6hLgQSJRuayzNoUzSS_Og.0

Link to failure log : https://treeherder.mozilla.org/logviewer?job_id=354718530&repo=autoland&lineNumber=9610

Comment 13

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/3bb43ee4a954
Add profiler marker for core part of CC r=smaug,gerald
https://hg.mozilla.org/integration/autoland/rev/9c2d667cad6d
Pass through explicit ccIsManual to reduce usage of ccType r=smaug
https://hg.mozilla.org/integration/autoland/rev/620d1123ade3
Remove unused ccType from ShouldMergeZones r=smaug
https://hg.mozilla.org/integration/autoland/rev/027f4bc5efe6
Replace bools with CCReasons for the scheduler control variables. r=smaug
https://hg.mozilla.org/integration/autoland/rev/9a0e9dbfe524
Track CCReason for all cycle collections (replacing ccType) r=smaug
https://hg.mozilla.org/integration/autoland/rev/87d6b8574dd8
Add the CC reason to CC profile markers r=gerald

Comment 14

[Steve Fink [:sfink] [:s:]]

The 4th try is sticking so far...

Comment 15

[Noemi Erli[:noemi_erli]]

https://hg.mozilla.org/mozilla-central/rev/3bb43ee4a954
https://hg.mozilla.org/mozilla-central/rev/9c2d667cad6d
https://hg.mozilla.org/mozilla-central/rev/620d1123ade3
https://hg.mozilla.org/mozilla-central/rev/027f4bc5efe6
https://hg.mozilla.org/mozilla-central/rev/9a0e9dbfe524
https://hg.mozilla.org/mozilla-central/rev/87d6b8574dd8